Skip to content
This repository has been archived by the owner on Dec 26, 2023. It is now read-only.

Ignore files outside of repository root #92

Closed
christianbumann opened this issue Nov 15, 2019 · 2 comments · Fixed by #170
Closed

Ignore files outside of repository root #92

christianbumann opened this issue Nov 15, 2019 · 2 comments · Fixed by #170
Assignees
Milestone

Comments

@christianbumann
Copy link
Member

This code doesn't make sense.
We should it refactor like this

@pascalberger
Copy link
Member

@christianbumann Do you remember what your exact issue is with the current implementation? Do you just miss the part which validates that the file is part of the repository?

@christianbumann
Copy link
Member Author

christianbumann commented Sep 1, 2021

@christianbumann Do you remember what your exact issue is with the current implementation? Do you just miss the part which validates that the file is part of the repository?

It‘s a long time ago and sorry for the bad description - my fault. As I can remember and if I look on the code, the method always returns true. Try-methods should always return true or false, and set the out parameter if true… So if this method always returns true it should be renamed and refactored so that the out param is the return value. But imho try is the better approach, but not for the actual code.

@pascalberger pascalberger self-assigned this Jul 23, 2022
@pascalberger pascalberger added this to the 2.0.0 milestone Jul 25, 2022
@pascalberger pascalberger changed the title Refactor code validating file path Ignore files outside of repository root Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants