Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cake.MinVer to target Cake v4.0.0 #86

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Update Cake.MinVer to target Cake v4.0.0 #86

merged 6 commits into from
Jul 30, 2024

Conversation

OsirisTerje
Copy link
Contributor

@OsirisTerje OsirisTerje commented May 25, 2024 •
edited
Loading

Fixes #71
Updated this to use Cake tool version 4 to get rid of the warning

The assembly 'Cake.MinVer, Version=3.0.0.0, Culture=neutral, PublicKeyToken=null'
is referencing an older version of Cake.Core (3.0.0).
For best compatibility it should target Cake.Core version 4.0.0.

Once built, it needs to update its own tools, since it is referencing itself in version 3 and also cake.args at version 3. Cake.args have not been updated to 4.

@CLAassistant
Copy link

CLAassistant commented May 25, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@augustoproiete augustoproiete changed the title Updated cake tool to version 4, ref #71 Update Cake.MinVer to target Cake v4.0.0 Jul 30, 2024
augustoproiete
augustoproiete approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@augustoproiete augustoproiete merged commit 2cf9a6a into cake-contrib:master Jul 30, 2024
4 checks passed
@augustoproiete
Copy link
Member

@OsirisTerje your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustoproiete augustoproiete augustoproiete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Cake.MinVer to target Cake v4.0.0
3 participants
@OsirisTerje @CLAassistant @augustoproiete