Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CW-580: BIP39 Wallets Shared Seed Implementation: "One Seed - Multiple Wallets" #1307

Merged
merged 45 commits into from
Sep 20, 2024
Merged

CW-580: BIP39 Wallets Shared Seed Implementation: "One Seed - Multiple Wallets" #1307

merged 45 commits into from
Sep 20, 2024

Conversation

Blazebrain
Copy link
Contributor

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

@Blazebrain Blazebrain marked this pull request as ready for review February 21, 2024 16:40
@Blazebrain Blazebrain self-assigned this Feb 21, 2024
@tuxpizza tuxpizza linked an issue Feb 25, 2024 that may be closed by this pull request
One seed multi wallets, is it possible? #1035
Closed
Blazebrain and others added 20 commits April 8, 2024 16:11
@Blazebrain
Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …
bfefe67 
…CW-580-BIP39-Wallets-Same-Seed
@Blazebrain
feat: Use same seed for BIP39 Wallets
dc7ff94
@Blazebrain
Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …
f1b7b7a 
…CW-580-BIP39-Wallets-Same-Seed
@Blazebrain
Update pre_existing_seeds_page.dart
3b3302f
@Blazebrain
Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …
1903ff2 
…CW-580-BIP39-Wallets-Same-Seed
@Blazebrain
Feat: BIP39 Same seed wallet creation using the Common Parent Wallet …
c86d256 
…Strategy
@Blazebrain
Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …
846a599 
…CW-580-BIP39-Wallets-Same-Seed
@Blazebrain
feat: Finalize implementing preexisting seeds
26707ac
@Blazebrain
feat: Implement shared bip39 wallet seed for Bitcoin wallet type
90e810f
@Blazebrain
feat: Implement shared bip39 wallet seed for Litecoin wallet type
13b8078
@Blazebrain
feat: Implement shared bip39 wallet seed for BitcoinCash wallet type
44d78ae
@Blazebrain
feat: Implement shared bip39 wallet seed for Nano wallet type, althou…
16f3e1d 
…gh disabled entry for now
@Blazebrain
fix: Remove non bip39 seed wallet type from listing
58d87c5
@Blazebrain
feat: Implement grouped and single wallets lists in wallets listing p…
973ad89 
…age and implement editing and saving group names
@Blazebrain
fix: Issue where the ontap always references the leadwallet, also mak…
359c9a0 
…e shared seed wallets section header only display when the multi wallet groups list is not empty
@Blazebrain
Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …
8ac44e7 
…CW-580-BIP39-Wallets-Same-Seed
@Blazebrain
fix: Add translation and adjust the way the groups display
4e940ae
@Blazebrain
feat: Activate bip39 as an option for creating Nano wallet types
2fcc4d7
@Blazebrain
fix: Handle edgecase with creating new wallet with group address, han…
0bd95f8 
…dle case where only bip39 derivation type is allowed with child wallets, activate nano wallet type for shared seed
@Blazebrain
chore: Modify the UI to fit adjustment made on figma
1f32a1f
@Blazebrain Blazebrain changed the title CW-580: Implement creating new BIP39 wallet with same seed used for other BIP39 owned Wallets CW-580: BIP39 Wallets Shared Seed Implementation: "One Seed - Multiple Wallets" Sep 9, 2024
OmarHatem28
OmarHatem28 requested changes Sep 16, 2024
View reviewed changes
lib/src/screens/new_wallet/new_wallet_type_page.dart Outdated Show resolved Hide resolved
lib/view_model/new_wallet_type_view_model.dart Outdated Show resolved Hide resolved
lib/reactions/bip39_wallet_utils.dart Outdated Show resolved Hide resolved
lib/router.dart Outdated Show resolved Hide resolved
lib/router.dart Outdated Show resolved Hide resolved
lib/view_model/wallet_new_vm.dart Outdated Show resolved Hide resolved
lib/view_model/wallet_new_vm.dart Outdated Show resolved Hide resolved
lib/entities/wallet_group.dart Outdated Show resolved Hide resolved
lib/entities/wallet_manager.dart Outdated Show resolved Hide resolved
cw_nano/lib/nano_wallet_service.dart Show resolved Hide resolved
Blazebrain and others added 19 commits September 17, 2024 17:10
@Blazebrain @OmarHatem28
Update lib/reactions/bip39_wallet_utils.dart [skip ci]
a021218 
Co-authored-by: Omar Hatem <omarh.ismail1@gmail.com>
@Blazebrain @OmarHatem28
Update lib/router.dart [skip ci]
483fbc1 
Co-authored-by: Omar Hatem <omarh.ismail1@gmail.com>
@Blazebrain
Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …
c76c9b5 
…CW-580-BIP39-Wallets-Same-Seed
@Blazebrain
Merge branch 'main' of https://github.com/cake-tech/cake_wallet into …
328ebe3 
…CW-580-BIP39-Wallets-Same-Seed
@Blazebrain
fix: Review fixes: Combine New Wallet Page Type arguments into a sing…
00189db 
…le model
@Blazebrain
fix: Review fixes: Add failure guard when fetching mnemonic for selec…
601d9bf 
…ted wallet in pre-existing wallets page
@Blazebrain
fix: Review fixes - Add loading indicator when mnemonic is being sele…
36a38bf 
…cted for wallet
@Blazebrain
fix: Review fixes - Modify variable name to avoid clashes
a742747
@Blazebrain
fix: Review fixes - Access WalletManager through dependency injection…
13b4736 
… instead of service location
@Blazebrain
fix: Review fixes - Add testnet to convertWalletInfoToWalletlistItem …
b226cc0 
…function, and adjust according where used
@Blazebrain
fix: Review fixes - Add walletPassword to nano, tron and wownero wall…
b6f7639 
…ets and confirm it is properly handled as it should be
@Blazebrain
fix: Remove leadWallet, modify filtering flow to reflect this and not…
2a44c30 
… depend on leadWallet, and adjust privacy settings
@Blazebrain
fix: Review Fixes - Modify restore flow to reflect current nature of …
b014cb7 
…bip39 as default for majority of wallet types
@Blazebrain
Merge branch 'CW-580-BIP39-Wallets-Same-Seed' of https://github.com/c…
89c31ad 
…ake-tech/cake_wallet into CW-580-BIP39-Wallets-Same-Seed
@Blazebrain
fix: QA Fixes - Modify preexisting page to display wallet group names…
65c1d21 
… if set, and display them in incremental order if not set
@Blazebrain
fix: Add wallet group description page and rename pre-existingseeds p…
44c3515 
…age to wallet group display page
@Blazebrain
fix: Product Fix - Rename pre-existing seeds file name to wallet grou…
c3ec7fc 
…p display filename
@Blazebrain
fix: Product fix - Separate multiwallets groups from single wallets a…
0c350f5 
…nd display separately
@Blazebrain
fix - Product Fix - Add empty state for wallet group listing when cre…
8dedc1f 
…ating a new wallet, adjust CTAs across buttons relating to the flow also
@OmarHatem28 OmarHatem28 merged commit 4e2e5e7 into main Sep 20, 2024
2 checks passed
@OmarHatem28 OmarHatem28 deleted the CW-580-BIP39-Wallets-Same-Seed branch September 20, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarHatem28 OmarHatem28 OmarHatem28 approved these changes

Assignees

@Blazebrain Blazebrain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

One seed multi wallets, is it possible?
2 participants
@Blazebrain @OmarHatem28