WIP: CW-665 Implement AirGapped Monero Transactions #1535

MrCyjaneK · 2024-07-16T21:10:33Z

Description

Work in progress for the airgap.

How to test

Download offline wallet of choice
1. xmruw - Unnamed Monero Wallet (project of mine, used during development)
  1. https://github.com/MrCyjaneK/unnamed_monero_wallet/releases/download/v1.0.0-RC61/app-clean_monero-release.apk
  2. on Let's start! screen click "Other options" (below "Normal Wallet" button) and select Offline Wallet
  3. you can either create a new wallet or restore existing (polyseed and legacy seeds are supported, with passphrase offsets)
  4. optional if you feel like breaking my work is a great idea you can go to 3 dot menu -> configuration -> and check showExtraOptions - it will show extra options in 3 dots menu that will allow you to generate URQRs that are not supported, cake wallet should handle all QR codes gracefully (i.e. throw error but not crash), also no matter what you scan it should work.
2. anonero.io (tor browser required to visit link)
  1. download ANON flavor of the app, and on setup screen do not input node details, offline wallet will be created
3. feather wallet
  1. (no idea, don't remember, please contibute)
Create view-only wallet
1. Download cake wallet from this PR (last one with CW-665 in slack, or from github artifacts)
2. Create a view-only wallet
  1. via keys -> input only primary address, secret spend key and restore height
  2. via qr code -> generate NERO format (supported in xmruw, anonero and I think feather)
Initial balance after sync may be wrong - open drawer on the right and use Export outputs to sync outputs to offline wallet, and get key images in exchange.
Create transaction in cake wallet, scan the codes using the QR code scanner icon located in right upper corner (in xmruw and anonero)

Pull Request - Checklist

Drop MLKit on MacOS and iOS MrCyjaneK/fast_scanner#20
Initial Manual Tests Passed
Double check modified code and verify it with the feature/task requirements
Format code
Look for code duplication
Clear naming for variables and methods

use gsed or otherwise it fails?

.github/workflows/cache_dependencies.yml

lib/src/screens/exchange_trade/exchange_trade_page.dart

cw_monero/lib/api/wallet.dart

lib/src/screens/transaction_details/rbf_details_page.dart

lib/src/widgets/setting_actions.dart

cw_monero/lib/monero_wallet.dart

lib/entities/qr_scanner.dart

lib/view_model/restore/wallet_restore_from_qr_code.dart

lib/src/screens/dashboard/widgets/menu_widget.dart

scripts/android/pubspec_gen.sh

lib/view_model/send/send_view_model.dart

cw_monero/lib/monero_wallet.dart

cw_monero/lib/api/transaction_history.dart

lib/entities/qr_scanner.dart

MrCyjaneK · 2024-10-23T13:38:42Z

used for what?

useUR is set when we do want to send transaction over qrcodes.

lib/src/screens/dashboard/widgets/menu_widget.dart

remove return Container() for non monero wallets

lib/view_model/send/send_view_model.dart

don't handle empty qr codes

display primary address in seed screen

OmarHatem28 · 2024-11-04T13:38:50Z

lib/entities/default_settings_migration.dart

@@ -843,7 +843,7 @@ Future<void> changeDefaultMoneroNode(
    }
  });

-  final newCakeWalletNode = Node(uri: newCakeWalletMoneroUri, type: WalletType.monero);
+  final newCakeWalletNode = Node(uri: newCakeWalletMoneroUri, type: WalletType.monero, trusted: true);


like this it will be set to trusted for new installs only, can you please add it as a migration step (i.e case 42:) and change it for existing users as well

also let's add to the restore from QR card the Cupcake option
i.e just change the description of the Scan QR code card in the restore options to be something like

Add a cold wallet or recover a paper wallet or add your read-only wallet from Cupcake

@tuxpizza if you have another idea to show cupcake here please chime in

OmarHatem28 · 2024-11-09T04:37:28Z

lib/entities/default_settings_migration.dart

+        case 43:
+          await changeDefaultMoneroNode(nodes, sharedPreferences);
+          break;


how is calling this function going to make the node trusted?
like this it will only delete the node and add it back, which will still default trusted to false

make a new function that would just change the trusted boolean for our node to true

and please resolve the conflicts and change the text of the card

tuxpizza · 2024-11-09T05:26:33Z

Hey can we move the "Export outputs" option in the menu to the same position that Silent Payments and MWEB settings is at?

…CW-665-implement-air-gapped-monero-transactions # Conflicts: # ios/Podfile.lock # res/values/strings_ar.arb # res/values/strings_bg.arb # res/values/strings_cs.arb # res/values/strings_de.arb # res/values/strings_en.arb # res/values/strings_es.arb # res/values/strings_fr.arb # res/values/strings_ha.arb # res/values/strings_hi.arb # res/values/strings_hr.arb # res/values/strings_hy.arb # res/values/strings_id.arb # res/values/strings_it.arb # res/values/strings_ja.arb # res/values/strings_ko.arb # res/values/strings_my.arb # res/values/strings_nl.arb # res/values/strings_pl.arb # res/values/strings_pt.arb # res/values/strings_ru.arb # res/values/strings_th.arb # res/values/strings_tl.arb # res/values/strings_tr.arb # res/values/strings_uk.arb # res/values/strings_ur.arb # res/values/strings_vi.arb # res/values/strings_yo.arb # res/values/strings_zh.arb

- update locales - fix conflicts - move menu item

replace qr scanner with fast_scanner

415e1aa

MrCyjaneK marked this pull request as draft July 16, 2024 21:10

MrCyjaneK added 3 commits July 17, 2024 07:52

bump java version

b7408d6

fix qr code scanning

13be92f

add flashlight and camera switch

5c105f1

MrCyjaneK force-pushed the CW-665-implement-air-gapped-monero-transactions branch from c53a296 to 5c105f1 Compare July 17, 2024 07:59

MrCyjaneK added 20 commits July 23, 2024 13:34

airgap work

2b1ec0d

Merge branch 'main' into CW-665-implement-air-gapped-monero-transactions

de0383d

commitTransactionUR

16d9e0f

Merge branch 'main' into CW-665-implement-air-gapped-monero-transactions

58fd4fe

bump fast_scanner, fix configure script

d6333b0

add option to restore wallet from NERO qr format

83dde69

fixes to the flow and logic

8b1584a

use gsed or otherwise it fails?

remove Expanded() to fix URQR on release builds

70e4b3e

cache key to allow app updates

1bba84d

rename cache key

5ee9205

[skip ci] cache key.jks in cache_dependencies

4514971

Merge branch 'main' into CW-665-implement-air-gapped-monero-transactions

da11a1e

Merge branch 'main' into CW-665-implement-air-gapped-monero-transactions

99bf1dd

update fast_scanner to work on ios, with light mlkit dependency

f5196ea

Merge branch 'main' into CW-665-implement-air-gapped-monero-transactions

ac1a131

ui fixes

9772e2c

error handling fix

285aa16

update fast_scanner to drop iOS dependency

44e3d07

Merge branch 'main' into CW-665-implement-air-gapped-monero-transactions

ba2d5fb

Merge branch 'main' into CW-665-implement-air-gapped-monero-transactions

93df370

OmarHatem28 requested changes Oct 22, 2024

View reviewed changes

OmarHatem28 marked this pull request as ready for review October 22, 2024 00:22

MrCyjaneK added 2 commits October 22, 2024 16:46

changes from review

bcf0e1f

Merge branch 'main' into CW-665-implement-air-gapped-monero-transactions

03f3db5

OmarHatem28 reviewed Oct 22, 2024

View reviewed changes

OmarHatem28 approved these changes Oct 22, 2024

View reviewed changes

lib/entities/qr_scanner.dart Outdated Show resolved Hide resolved

Update lib/entities/qr_scanner.dart

c5620cb

MrCyjaneK added 2 commits October 23, 2024 16:03

changes from review

4fe3822

remove useless commit

bd830f5

OmarHatem28 reviewed Oct 23, 2024

View reviewed changes

lib/src/screens/dashboard/widgets/menu_widget.dart Outdated Show resolved Hide resolved

don't set state multiple times

083194c

remove return Container() for non monero wallets

OmarHatem28 reviewed Oct 23, 2024

View reviewed changes

lib/view_model/send/send_view_model.dart Show resolved Hide resolved

MrCyjaneK added 3 commits October 23, 2024 17:58

return on fail

3416d8e

don't handle empty qr codes

set node as trusted

f8f2c55

display primary address in seed screen

fix wow and haven

284d261

OmarHatem28 reviewed Nov 4, 2024

View reviewed changes

migrate node to trusted

bbf702a

OmarHatem28 reviewed Nov 9, 2024

View reviewed changes

OmarHatem28 added 2 commits November 9, 2024 19:57

- update trusted node for existing users

2d2fcfe

- update locales - fix conflicts - move menu item

OmarHatem28 merged commit cea3084 into main Nov 9, 2024
2 checks passed

OmarHatem28 deleted the CW-665-implement-air-gapped-monero-transactions branch November 9, 2024 18:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: CW-665 Implement AirGapped Monero Transactions #1535

WIP: CW-665 Implement AirGapped Monero Transactions #1535

MrCyjaneK commented Jul 16, 2024 •

edited

Loading

MrCyjaneK commented Oct 23, 2024

OmarHatem28 Nov 4, 2024

OmarHatem28 Nov 7, 2024

OmarHatem28 Nov 7, 2024

OmarHatem28 Nov 9, 2024

OmarHatem28 Nov 9, 2024

tuxpizza commented Nov 9, 2024

WIP: CW-665 Implement AirGapped Monero Transactions #1535

WIP: CW-665 Implement AirGapped Monero Transactions #1535

Conversation

MrCyjaneK commented Jul 16, 2024 • edited Loading

Description

How to test

Pull Request - Checklist

MrCyjaneK commented Oct 23, 2024

OmarHatem28 Nov 4, 2024

Choose a reason for hiding this comment

OmarHatem28 Nov 7, 2024

Choose a reason for hiding this comment

OmarHatem28 Nov 7, 2024

Choose a reason for hiding this comment

OmarHatem28 Nov 9, 2024

Choose a reason for hiding this comment

OmarHatem28 Nov 9, 2024

Choose a reason for hiding this comment

tuxpizza commented Nov 9, 2024

MrCyjaneK commented Jul 16, 2024 •

edited

Loading