Set file type to scss, revert #17 #41
Conversation
This reverts the merged pull request cakebaker#17. When the file type is set to 'scss.css', many other Sass-related plugins will not detect that a SCSS file is indeed a SCSS file. We should therefor use a file type that's as close to official as it gets, and since the two official file extensions are .sass and .scss, using 'scss' as file type is a good choice.
|
Hm, I'm unsure about this. I see your point but I don't know whether this is just a theoretical issue or a real one. Because the plugin you mention (vim-css-color) doesn't work with SCSS files here, whether the change is applied or not... On the other hand I see the benefit for the snipmate plugin mentioned in #17 (and so far I didn't encounter any issues with the I think that there are better ways to make CSS-related things work out of the box That's possible as I'm not a Vim expert. It's something I have to investigate. |
|
Thank you for your comment! The issue was fist reported in ap/vim-css-color#35 and affects me as well. I guess that makes it real, not just a theoretical one. However, since several plugins are involved, I’ll do some investigating myself to confirm that the issue is caused by this plugin, not any of the other plugins. I’m not using the snipmate plugin, but I’ll try it out and see if I can think of any other way to make it work «out of the box» with |
|
hi, I want to provide a remark that when the file type is set to |
|
It's also a problem for me. I've manually fixed for now... Regards. |
|
Me too. It will make ultisnips to use css and scss snippets. And then if use |
|
Ok, you guys convinced me ;-) I reverted the change and added a hint to the readme. Thanks for your comments. |
My opinion is that the file type of SCSS files should be
scss, notscss.css. Mostly because the two syntaxes available for Sass; SCSS and Sass, use the file extensions.scssand.sass, but also because several other plugins, such as vim-css-color, is affected by the Sass syntax and file type set by this plugin.When the file type is set to
scss.css, these other plugins will not detect that the SCSS file is indeed a SCSS file. This results in the plugins being unable to do their job, which is not good.The merged pull request #17 allowed "css-related things to work straight away with scss files", but I think that there are better ways to make CSS-related things work out of the box than changing the file type to something that breaks compatibility with other plugins.