Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run composer normalize over composer.json #975

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

dereuromark
Copy link
Member

Auto created via toolbox app.

@dereuromark
Copy link
Member Author

If this is something we want to do to normalize it across all repos, I can run the tool over all relevant repos.
Just let me know.

There might be more merge conflicts at the start, but then should minimize afterwards.

Copy link
Member

@ravage84 ravage84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I do like uniformity most often, I'm not sure I like it in this "opinionated" way. 🤷

@dereuromark
Copy link
Member Author

Is it? Afaik it aligns itself according to the underlying JSON schema
So it just follows what composer dictates as Schema it seems.

@othercorey
Copy link
Member

othercorey commented Nov 27, 2023

Looks ok to me. I remember doing this manually once, but I guess I never committed.

@othercorey othercorey added this to the 5.x milestone Nov 27, 2023
@othercorey othercorey merged commit 5eda5a6 into 5.x Nov 27, 2023
8 checks passed
@othercorey othercorey deleted the composer-normalize branch November 27, 2023 17:18
@LordSimal
Copy link
Contributor

The only thing that's weird to me is the position of the suggest block. Everything is fine by me 👍🏻
But I guess we can all get used to it. Would love to see it across all our repos AND a github CI check

@dereuromark
Copy link
Member Author

dereuromark commented Nov 27, 2023

Well, we can reach out to composer and ask them to fix up the order as per our suggestions - pun intended :)
Before we further modify more repos.

As for the CI check: Might be a bit overkill, so often we will not change the structure as a whole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants