Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.x nesting depth #991

Merged
merged 3 commits into from
Jan 26, 2024
Merged

5.x nesting depth #991

merged 3 commits into from
Jan 26, 2024

Conversation

dereuromark
Copy link
Member

@dereuromark dereuromark commented Jan 26, 2024

This has been annoying the heck out of me for the last months

All the time, the default level of 3 for the other tabs (not Variables, which is already 5) is usually never enough, especially for session

Auth.User.Profile.Image.id

etc

Fun fact: current level 3 doesnt even show content of Profile, so the count seems to be cut off already on level 2...

For now I always have to either

  • hack the debug kit by putting a change into the Panel code inside vendor/, to increase to e.g. 5, bad idea
  • workaround it using dd() or other debugging tools in the end

not being able to trust debug kit to give me the details after clicking through the tree of elements only to find [maximum depth reached]

So I recommend we default to 5 here in general, and allow the other tabs to be configured as well.
I on purpose used a different key, as VariablesPanel is sure different as it contains really a LOT of data, compared to the others, So keeping that one at 5 while allowing the others to be safely used on e.g. 8 makes sense to me.

@dereuromark dereuromark added this to the 5.x milestone Jan 26, 2024
@markstory markstory merged commit 8dbb82e into 5.x Jan 26, 2024
7 of 8 checks passed
@markstory markstory deleted the 5.x-nesting-depth branch January 26, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants