Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graph loaders when changing year/stop purpose using dropdowns #277

Conversation

Afani97
Copy link
Contributor

@Afani97 Afani97 commented Feb 26, 2024

What's changed:

  • Show a loading message for graphs that fetch new data after user uses dropdown to change year, stop purpose, etc. To prevent confusion for some graphs load longer.

@@ -47,28 +47,35 @@ function Contraband(props) {

const renderMetaTags = useMetaTags();
const [renderTableModal] = useTableModal();
const [contrabandData, setContrabandData] = useState({

const initContrabandData = {
labels: [],
datasets: [],
isModalOpen: false,
tableData: [],
csvData: [],
loading: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This loading flag will show a Loading data component while data is being fetched.

@Afani97 Afani97 merged commit 3766793 into develop Feb 26, 2024
1 check passed
@Afani97 Afani97 deleted the add-loading-screens-per-graph-when-updating-graphs-by-dropdowns branch February 26, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant