Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-12] Discovers deploy account name from the Service Account #36

Merged
merged 5 commits into from
Jan 27, 2021
Merged

[ISSUE-12] Discovers deploy account name from the Service Account #36

merged 5 commits into from
Jan 27, 2021

Conversation

JeremyGibson
Copy link
Contributor

@JeremyGibson JeremyGibson commented Jan 27, 2021 •
edited
Loading

Closes: #12

copelco
copelco reviewed Jan 27, 2021
View reviewed changes
tasks/main.yml Outdated Show resolved Hide resolved
copelco
copelco approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@copelco copelco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'd change Get deploy account name to Get deploy account, since it's getting the full details in this call

@JeremyGibson JeremyGibson merged commit f0c0f6d into master Jan 27, 2021
@JeremyGibson JeremyGibson deleted the ISSUE-12-deploy-account-name-missing branch January 27, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copelco copelco copelco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sometimes when creating the deploy account token, it comes back in a different order
2 participants
@JeremyGibson @copelco