Align targetSdkVersion in manifests and build script #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoody
force-pushed
the
feature/align-sdk-versions-in-manifests-and-build-script
branch
2 times, most recently
from
9345265
to
07f313d
Compare
1. server/AndroidManifest.xml and 2. server/instrumentation-backend/AndroidManifest.xml now have the same SDK versions
and ensures that the target and min SDK are the same in both files: * server/AndroidManifest.xml * server/instrumentation-backend/AndroidManifest.xml
jmoody
force-pushed
the
feature/align-sdk-versions-in-manifests-and-build-script
branch
from
e286784
to
2b526c8
Compare
jmoody
force-pushed
the
feature/align-sdk-versions-in-manifests-and-build-script
branch
from
2b526c8
to
4a1f7f1
Compare
jmoody
deleted the
feature/align-sdk-versions-in-manifests-and-build-script
branch
This was referenced Dec 14, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Aligns the
targetSdkVersionandminSdkVersionacross these three sources:The build script now reads the two manifests and errors out if the two version keys are not equal.