Comparison of Array with Array failed for marks and text

[TeresaP]

When I called marks and text on my app, I got:

irb(main):001:0> marks
ArgumentError: comparison of Array with Array failed
    from /Library/Ruby/Gems/2.0.0/gems/calabash-cucumber-0.19.1/lib/calabash-cucumber/console_helpers.rb:41:in `sort'
    from /Library/Ruby/Gems/2.0.0/gems/calabash-cucumber-0.19.1/lib/calabash-cucumber/console_helpers.rb:41:in `marks'
    from (irb):1
    from /usr/bin/irb:12:in `<main>'

irb(main):002:0> text
ArgumentError: comparison of Array with Array failed
    from /Library/Ruby/Gems/2.0.0/gems/calabash-cucumber-0.19.1/lib/calabash-cucumber/console_helpers.rb:158:in `sort'
    from /Library/Ruby/Gems/2.0.0/gems/calabash-cucumber-0.19.1/lib/calabash-cucumber/console_helpers.rb:158:in `print_marks'
    from /Library/Ruby/Gems/2.0.0/gems/calabash-cucumber-0.19.1/lib/calabash-cucumber/console_helpers.rb:223:in `text_marks'
    from /Library/Ruby/Gems/2.0.0/gems/calabash-cucumber-0.19.1/lib/calabash-cucumber/console_helpers.rb:25:in `text'
    from (irb):2
    from /usr/bin/irb:12:in `<main>'

[jmoody]

@TeresaP The unit tests are failing.

$ be rspec spec/lib/console_helpers_spec.rb

[TeresaP]

Thanks @jmoody. I think the original method is choking because some of the array values are nil, like this:

What's another way we can solve this?

[jmoody]

On the array with nils - call compact which will remove nils.

[TeresaP]

@jmoody I think that causes a problem because sometimes we would end up with 2-element arrays and sometimes we would end up with 3-element arrays. Substituting empty strings for nil values seems to work though.

[jmoody]

@TeresaP Don't be afraid to update the tests if you think the behavior can be improved.

[ark-konopacki]

Shouldn't you replace at this line sort_by with 'sort'?
I think this is the root cause for failing tests ;)

[ark-konopacki]

@TeresaP please take a look on my comment i think i find why tests failing.
You can check tests locally with rspec spec/lib/console_helpers_spec.rb

[TeresaP]

@ark-konopacki thanks for taking a look :). I will have to give that a shot!

[jmoody]

@TeresaP I want to get this merged. Can you provide me a way to reproduce?

[jmoody]

I reproduced!!!!

[ark-konopacki]

@jmoody the only one issue with this PR is failing tests
please take a look at my previous comments it really easy to fix, but i cannot modify code at this PR ;)

[ark-konopacki]

@TeresaP @jmoody it can be really usefull to have this merged.
Teresa if you don't have time to fix it just give me know i'll create new PR and we can close yours.