Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Xcode's 'Shared Folder' and 'Custom' Derived Data location setting #704

Merged

Conversation

RuudPuts
Copy link

Like me, many developers use the 'Shared Folder' or 'Custom' location for their build and products, which can be set in Xcode's preferences via the 'Locations' tab and than clicking the 'Advanced...' button next to Derived Data.

When building your Calabash target for profiling, to use with start_test_server_in_background this would result in Calabash not being able to find your .app file. The pull request is an addition in simulator_launcher.rb which adds support for Xcode's Derived Data location setting when searching for the .app file to launch.

@jmoody
Copy link
Contributor

jmoody commented Feb 25, 2015

@RuudPuts Thanks for the pull-request.

Finding the .app is a challenging problem and one that we have wrestled with since day one.

I have a couple of concerns beyond the code comments.

  • Is this backward compatible to Xcode 5? One reason that we don't do more on this problem is that we don't want to chase Xcode more than we already do.
  • Does this have any effect on Xamarin Studio users? I know you cannot test this, but someone will have to investigate.
  • There are no tests that demonstrate this working.

@jmoody jmoody added this to the 0.13.* milestone Feb 25, 2015
@RuudPuts
Copy link
Author

Thanks for your reply Joshua. I'll implement PlistBuddy, add the tests and test on Xcode 5 and Xamarin Studio when I get my hands on it.

@jmoody jmoody removed this from the 0.13.* milestone Sep 11, 2015
@jmoody
Copy link
Contributor

jmoody commented Oct 24, 2015

@RuudPuts This is an excellent PR and really good idea.

I am going to implement this in run-loop so it can be leveraged for Calabash 2.0.

There are a couple edge cases that need to be sorted out. Shall I @mention you in the run-loop PR so you can track progress?

Nice work!

+100

@RuudPuts
Copy link
Author

@jmoody That would be awesome! Really looking forward to it, thanks!

@jmoody
Copy link
Contributor

jmoody commented Oct 26, 2015

After investigating this issue some more, I see this is a non-trivial problem. Implementing this code in run-loop will take a significant amount of time - I have started by there are many cases to handle.

I have decided I am going to merge this PR as is. It probably won't break anything and it looks to me like it work for most cases.

Thanks!

[iOS] Automatically detect application in xcode project #23

jmoody added a commit that referenced this pull request Oct 26, 2015
…tion

Add support for Xcode's 'Shared Folder' and 'Custom' Derived Data location setting
@jmoody jmoody merged commit 28fde13 into calabash:develop Oct 26, 2015
@jmoody
Copy link
Contributor

jmoody commented Dec 15, 2015

@arulami It would have been better if you created a new issue. A comment on a closed pull request will get lost.

Tracking this problem here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants