SimLauncher: fix autodetection of app bundle #974
Conversation
0.17.0 Cannot automatically detect app calabash#959
|
Can one of the admins verify this patch? |
|
Jenkins test this please. |
|
Can one of the admins verify this patch? |
|
@jmoody: Can you please review my changes, it looks ok for me now ;) |
| sim_dirs = Dir.glob(File.join(bo_dir, '*-iphonesimulator', '*.app')) | ||
| search_dir = build_output_dir_for_project || DERIVED_DATA | ||
| sim_dirs = '' | ||
| apps = `find #{search_dir} -name "*.app" | sort -n`.split("\n") |
There was a problem hiding this comment.
Interesting! Why sort numerically (-n)?
We want to search for the modification time and take the newest.
find #{search_dir} -type d -name "*.app" -exec stat -f "%m %N" {} \; | sort -rn | cut -d" " -f2
There was a problem hiding this comment.
@jmoody my fault will fix it
There was a problem hiding this comment.
Be sure to search for directories; it will be faster - -type d.
| sim_dirs = Dir.glob(app_path) | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
In the worst case, this looks like it will iterate over all apps that found and then sim_dirs will be the last app that matches the criteria and not the first.
I think we want to use: apps.find do instead of apps.each
sim_dirs = apps.find do |app_path|
end
There was a problem hiding this comment.
@jmoody: maybe it can be done like by adding break after
sim_dirs = Dir.glob(app_path)
|
@ark-konopacki This is a patch. I think we will need to come back to this later once some changes have been released in run-loop. |
| sim_dirs = Dir.glob(File.join(bo_dir, '*-iphonesimulator', '*.app')) | ||
| search_dir = build_output_dir_for_project || DERIVED_DATA | ||
| sim_dirs = '' | ||
| apps = `find #{search_dir} -type d -name "*.app" -exec stat -f "%m %N" {} \\; | sort -rn | cut -d" " -f2`.split("\n") |
There was a problem hiding this comment.
I think we need to be careful of UTF-8 chars here.
We can use ruby's Find or Dir.glob + File.mtime to perform this operation.
|
@jmoody thanks for feedback, after calabash/run_loop#379 will be merged and released i propose to rewrite that patch with more clear and simple implementation. |
…to feature/fix-autodetection-of-app-bundle
Added UTF-8 filter to cut invalid byte sequence each replaced with find
|
@jmoody Rebased and updated ;) |
and add examples
* Improve error message when no .app can be found
|
This is a great start. There is work still to do here:
|
…of-app-bundle SimLauncher: fix autodetection of app bundle
Fix and improvement in searching mechanism
it can be used as a draft for future implementations in run_loop
0.17.0 Cannot automatically detect app #959