Fix CLI simctl install/uninstall: CoreSim manages stdio.pipe and 'remembers' that it already launched the simulator #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not shutdown Watch or TV simulators
Calling launch_simulator more than once causes the simulator to become unstable.
The simctl process is async and unpredictable - this strategy did not pan out. There were many cases where simctl just hung and timed out.
It is all about timing and getting the environment just so. I am giving up.
jmoody
added a commit
that referenced
this pull request
Oct 9, 2015
…rt-stdpipe-and-sim-relaunching Fix CLI simctl install/uninstall: CoreSim manages stdio.pipe and 'remembers' that it already launched the simulator
jmoody
deleted the
feature/improve-coresimulator-wrt-stdpipe-and-sim-relaunching
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes * Xcode 7: command line tools that use Simctl::Bridge are broken (blocking) #289
I started working on this PR to fix the
run-loop simctl installCLI which was hanging.While testing, I discovered a couple of problems:
Progress on
readcalls through utf-8 filter and come up with a way of testing Pass allreadcalls through utf-8 filter #230