Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All simctl commands are performed through Simctl instance #507

Merged
merged 22 commits into from
Aug 4, 2016
Merged

All simctl commands are performed through Simctl instance #507

merged 22 commits into from
Aug 4, 2016

Conversation

jmoody
Copy link
Contributor

@jmoody jmoody commented Aug 3, 2016

Motivation

Resolves:

  • calls to simctl need to guard against wrong CoreSimulator service loaded JIRA

Progress on:

This also brings us one step closer to being able to see if fbsimctl can be a replacement for simctl.

Test

Joshua, I am particularly interested to see these two integration examples pass on your machine:

$ git fetch
$ git co -to origin/feature/add-guard-for-incompatible-CoreSimulator-service
$ bundle update

$ be rspec spec/integration/simctl_spec.rb
$ be rspec spec/integration/core_simulator_spec.rb

@jmoody
Shell: add .run_shell_command class method
011fa80
@jmoody
Simctl: new instances ensure valid CoreSim service is loaded
22e3344
@jmoody
Style: prefer double quotes over single quotes
b651194 
In this case I need to search for the string simctl to be sure every call
is guarded (called in the context of a Simctl instance) - changing all
instances to have double quotes makes the search easier
@jmoody
Simctl: implement shutdown methods
f1477b7
@jmoody
Simctl: implement #erase simulator
b976cb2
@jmoody
CoreSim: implement erase with Simctl#erase
ec3109d
@jmoody
Simctl: implement launch app
14134f0
@jmoody
CoreSim: app launch is done with Simctl instance
c5da509 
* guards against invalid CoreSimulator service errors
* better retry behavior
* fixes flickering integration example
@jmoody
Simct: implement uninstall app
12b2d5c
@jmoody
CoreSim: calls uninstall through simctl
97680b2
@jmoody
Simctl: implement install app
c4e66be
@jmoody
CoreSim: implement install with Simctl instance
43142ed
@jmoody
Simctl: can return simulator state as a string
ef6a16a 
* Booted
* Shutdown
* Shuttting down
@jmoody
Device: updates simulator state with Simctl#simulator_state_as_string
f78857a
@jmoody
SimControl: add guards for incompatible CoreSimulator service
2e34632 
This class is slated for removal and is not used internally
@jmoody
Spec: remove ununsed simctl methods from Resources
5a99b59
@jmoody
Simctl: combine simctl life cycle methods into one example
0ec02e4
@jmoody
Simctl: execute => shell_out_with_xcrun
d30ad40
@jmoody jmoody added this to the 2.1.7 milestone Aug 3, 2016
@jescriba
Copy link
Contributor

jescriba commented Aug 4, 2016

@jmoody Looks good and the tests passed (locally) after one minor adjustment. Feel free to merge after you review the spec change.

@jmoody
Simctl: handle 'Shutdown' state if changes between check and call
d4f03ad 
It is possible for the simulator state to change between the first check and the
actual simctl shutdown call.  We now handle this case.
@jmoody
Spec: add sim plist check to core sim #erase specs
6d3ec90
@jmoody
Spec: remove example for deprecated Core.simulator_target? method
66b5854 
The method had an unguarded call to simctl
@jmoody
Copy link
Contributor Author

jmoody commented Aug 4, 2016

Thanks @jescriba

@jmoody jmoody merged commit 2446af2 into develop Aug 4, 2016
@jmoody jmoody deleted the feature/add-guard-for-incompatible-CoreSimulator-service branch August 4, 2016 12:19
@jmoody jmoody mentioned this pull request Aug 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jescriba jescriba

Labels
None yet
Projects
None yet
Milestone
2.1.7
Development

Successfully merging this pull request may close these issues.
2 participants
@jmoody @jescriba