Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Create Xero PKCE provider #15

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Conversation

davidwindell
Copy link
Contributor

Enables the use of PKCE Oauth2 flow when thephpleague/oauth2-client#901 is merged.

https://developer.xero.com/documentation/guides/oauth2/pkce-flow/

Marked as WIP until that branch is merged.

@rhertogh
Copy link

@davidwindell
Based on your feedback I've updated the docs/usage.md. Perhaps the oauth2-xero/README.md could be updated accordingly.

@davidwindell davidwindell changed the title [WIP] Create Xero PKCE provider Create Xero PKCE provider Sep 13, 2022
@davidwindell
Copy link
Contributor Author

The PKCE branch has been merged into oauth2-client, just waiting for an official release

@davidwindell davidwindell changed the title Create Xero PKCE provider [WIP] Create Xero PKCE provider Sep 13, 2022
@calcinai calcinai merged commit a8e85c5 into calcinai:master Sep 13, 2022
@calcinai
Copy link
Owner

calcinai commented Sep 13, 2022

Whoops! I jumped the gun–rather than focing this back, I will hold off on releasing this until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants