Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-1724] Allow global booking limits #8985

Open
ciaranha opened this issue May 19, 2023 · 8 comments · May be fixed by #14243
Open

[CAL-1724] Allow global booking limits #8985

ciaranha opened this issue May 19, 2023 · 8 comments · May be fixed by #14243
Labels
community Created by Linear-GitHub Sync event-types area: event types, event-types ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync
Milestone

Comments

@ciaranha
Copy link
Member

ciaranha commented May 19, 2023

Users can currently limit the number of times a single event gets booked.

We have received requests to allow people to limit bookings across all event types

This should live under global settings.

View designs

From SyncLinear.com | CAL-1724

@ciaranha ciaranha added ✨ feature New feature or request 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup labels May 19, 2023
@shirazdole
Copy link

We need to think about, do we want global booking limits to apply JUST to cal.com events or all events on my calendar.

I.e. let's say I manually schedule a catch-up call on Friday, and I have a daily limit of 5 bookings. Does this mean I only have four available slots, or do I have five?

If it's ONLY cal.com events, then I still have five bookings available, if it's ALL events then I have four available. Either way, we should make this clear on the documentation and under the feature :)

@ciaranha
Copy link
Member Author

ciaranha commented May 19, 2023

I.e. let's say I manually schedule a catch-up call on Friday, and I have a daily limit of 5 bookings. Does this mean I only have four available slots, or do I have five?

It's definitely a good point. For v1, I'm going to say it's most likely we will just count events from Cal.com. If you want an event to count towards the limit, do it through Cal.com. When this situation arises, you can book yourself and enter the bookers details or just your own with a note. We can also look to make it easier to "Add a booking" specifically for these cases.

@shirazdole
Copy link

Excellent!! Especially the “add a booking” portion

@ciaranha ciaranha added the Medium priority Created by Linear-GitHub Sync label May 19, 2023
@riteshsp2000
Copy link
Contributor

@Jaibles @shirazdole

I find this particular feature promising and would like to work on it. While I do have a few uncertainties regarding the specific implementation particulars, once those are resolved, I'll be ready to commence with the necessary code modifications.

@PeerRich PeerRich added the event-types area: event types, event-types label Jul 3, 2023
@nicktrn
Copy link
Contributor

nicktrn commented Aug 2, 2023

I've been working on the existing booking + frequency limits and have come across some unclear design aspects. Thought it best to raise this here as it will affect global limits too.

  1. Only events that start AND end in the same limited period are counted towards said limit. (*)
  2. Buffers are being counted towards duration limits. I expect this is NOT desired.
  3. Existing limit periods: day, week, month, year. What about quarterly limits?
  4. Localisation seems to be missing for the period labels

(*) This makes a certain group of bookings, e.g. overnight, multi-day, immune to limits of the period(s) they cross. Then again, I'm unsure it's even possible to make bookings of that nature (but probably should be) - see #6054

@ciaranha
Copy link
Member Author

Designs attached

@ciaranha ciaranha removed the 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup label Dec 12, 2023
@keithwillcode keithwillcode added this to the v3.9 milestone Feb 6, 2024
@ciaranha ciaranha modified the milestones: v3.9, v4.0 Feb 16, 2024
@asadath1395 asadath1395 linked a pull request Mar 28, 2024 that will close this issue
1 task
@ciaranha ciaranha added the community Created by Linear-GitHub Sync label Apr 2, 2024
@keithwillcode keithwillcode modified the milestones: v4.0, v4.1 Apr 15, 2024
@ciaranha ciaranha modified the milestones: v4.1, v4.2 May 15, 2024
@Tchouk
Copy link

Tchouk commented Jun 15, 2024

Hi team, any news about this feature? 🙂

@ciaranha ciaranha modified the milestones: v4.2, v4.3 Jun 17, 2024
@keithwillcode keithwillcode modified the milestones: v4.3, v4.4 Jul 16, 2024
@keithwillcode keithwillcode modified the milestones: v4.4, v4.5 Aug 19, 2024
@ciaranha ciaranha removed community Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync labels Sep 4, 2024
@ciaranha ciaranha added the High priority Created by Linear-GitHub Sync label Sep 4, 2024
@CarinaWolli CarinaWolli removed their assignment Sep 9, 2024
@CarinaWolli CarinaWolli added Medium priority Created by Linear-GitHub Sync and removed High priority Created by Linear-GitHub Sync labels Sep 9, 2024
@CarinaWolli CarinaWolli modified the milestones: v4.5, v4.6 Sep 9, 2024
@CarinaWolli
Copy link
Member

Additional information: Global bookings limits for users should only be for user event types and it should not include bookings from team event types.

Teams will have their own global booking limits: #16557

@ciaranha ciaranha added the community Created by Linear-GitHub Sync label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync event-types area: event types, event-types ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants