-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-day availability hours and event bookings. #6054
Comments
huh interesting. we'd need to investigate how to do this best |
Interesting! Thanks @emrysal for following up. Does the fix then allow for overnight bookings? I'd guess that it technically wouldn't since there is an unaccounted gap between 11:59:00 and 00:00:00 ? edit: Actually, after reading the code it looks like you do indeed account for that gap with a cheeky replace? |
The end time isn't used for the most part while scheduling, it's mainly based on start times - but the lack of the 23:59 option prevented the 23:45 option from being selected (23:30 being the latest possible to select). A complicated story short, in theory an overnight booking should now work The cheeky replace is just for the availability page, as endOf() is used which is the last millisecond of the day, but in our database we only have minute granularity. |
@emrysal thank you! Looking forward to testing it out on release :) |
Unfortunately @emrysal it didn't work :( |
Is your proposal related to a problem?
Describe the solution you'd like
Events should be able to be booked across midnight.
I think allowing the Availability Hours to be set a different way would help fix this problem.
Perhaps by showing the whole week graphically, allowing people to "colour in" their free time AND having an option that says "allow multi-day events" or "allow events to cross midnight"
Describe alternatives you've considered
I've tried using the "Add new time slot" button to counteract this problem, but it still won't allow events to be booked across midnight.
Additional context
n/a
The text was updated successfully, but these errors were encountered: