Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-day availability hours and event bookings. #6054

Closed
12ian34 opened this issue Dec 16, 2022 · 6 comments · Fixed by #6137
Closed

Multi-day availability hours and event bookings. #6054

12ian34 opened this issue Dec 16, 2022 · 6 comments · Fixed by #6137
Assignees

Comments

@12ian34
Copy link

12ian34 commented Dec 16, 2022

Is your proposal related to a problem?

  • When using Availability hours, the last available time in the 'end time selector' is 23:45.
  • This means that it isn't possible for events to be booked than run past 23:45.
  • I would like to be able to have events booked across midnight.
  • Availability hours are currently set per each single day, via specific time slot periods, each with start and end times, in "time periods" that can only start after the previously set "time period" has finished. This is quite annoying, because it isn't a great representation of "free time".

image

Describe the solution you'd like

Events should be able to be booked across midnight.
I think allowing the Availability Hours to be set a different way would help fix this problem.
Perhaps by showing the whole week graphically, allowing people to "colour in" their free time AND having an option that says "allow multi-day events" or "allow events to cross midnight"

Describe alternatives you've considered

I've tried using the "Add new time slot" button to counteract this problem, but it still won't allow events to be booked across midnight.

Additional context

n/a

@PeerRich
Copy link
Member

huh interesting. we'd need to investigate how to do this best

@emrysal
Copy link
Contributor

emrysal commented Dec 21, 2022

@12ian34 I believe this may be fixed by #6137

@emrysal emrysal linked a pull request Dec 21, 2022 that will close this issue
@emrysal emrysal self-assigned this Dec 21, 2022
@12ian34
Copy link
Author

12ian34 commented Dec 21, 2022

Interesting! Thanks @emrysal for following up. Does the fix then allow for overnight bookings? I'd guess that it technically wouldn't since there is an unaccounted gap between 11:59:00 and 00:00:00 ?

edit: Actually, after reading the code it looks like you do indeed account for that gap with a cheeky replace?

@emrysal
Copy link
Contributor

emrysal commented Dec 21, 2022

The end time isn't used for the most part while scheduling, it's mainly based on start times - but the lack of the 23:59 option prevented the 23:45 option from being selected (23:30 being the latest possible to select). A complicated story short, in theory an overnight booking should now work

The cheeky replace is just for the availability page, as endOf() is used which is the last millisecond of the day, but in our database we only have minute granularity.

@12ian34
Copy link
Author

12ian34 commented Dec 21, 2022

@emrysal thank you! Looking forward to testing it out on release :)

@12ian34
Copy link
Author

12ian34 commented Mar 9, 2023

Unfortunately @emrysal it didn't work :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants