Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: autosave availability after making changes #14849

Merged
merged 7 commits into from
May 27, 2024
Merged

feat: autosave availability after making changes #14849

merged 7 commits into from
May 27, 2024

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented May 1, 2024 •
edited
Loading

What does this PR do?

Fixes #14591

Working.Hours._.Availability._.Cal.com.and.5.more.pages.-.Personal.-.Microsoft_.Edge.2024-05-02.03-36-55.mp4

@vercel Vercel
Copy link

vercel bot commented May 1, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 1, 2024
@graphite-app graphite-app bot requested a review from a team May 1, 2024 22:05
@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking Medium priority Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI labels May 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added the ✨ feature New feature or request label May 1, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented May 1, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/01/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/01/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@Udit-takkar Udit-takkar added this to the v4.1 milestone May 3, 2024
@supalarry supalarry self-requested a review May 3, 2024 09:05
supalarry
supalarry requested changes May 3, 2024
View reviewed changes
Copy link
Contributor

@supalarry supalarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix

When day e.g. "Friday" is toggled 2 confirmation messages appear instead of 1.
Loom: https://www.loom.com/share/627cca63e7f44adcb3e32d63eacdbb2c

Screenshot 2024-05-03 at 11 05 23

UX thoughts

  1. Should we remove the "Save" button? It has no purpose if the form is autosaved.
  2. I would also simplify confirmation messages when something is saved e.g. instead of changing timezone and seeing toast "✔ Working Hours schedule updated successfully" just display "✔ Saved" - the confirmation toast messages are too long IMO.

@itsberkaya @ciaranha thoughts?

@anikdhabal
Copy link
Contributor Author

To fix

When day e.g. "Friday" is toggled 2 confirmation messages appear instead of 1. Loom: https://www.loom.com/share/627cca63e7f44adcb3e32d63eacdbb2c

Screenshot 2024-05-03 at 11 05 23 ## UX thoughts 1. Should we remove the "Save" button? It has no purpose if the form is autosaved. 2. I would also simplify confirmation messages when something is saved e.g. instead of changing timezone and seeing toast "✔ Working Hours schedule updated successfully" just display "✔ Saved" - the confirmation toast messages are too long IMO.

@itsberkaya @ciaranha thoughts?

Thanks for the review, I will fix that.

@dosubot dosubot bot modified the milestones: v4.1, v4.2 May 9, 2024
@Udit-takkar Udit-takkar marked this pull request as draft May 17, 2024 12:21
@anikdhabal anikdhabal marked this pull request as ready for review May 23, 2024 22:12
@github-actions github-actions bot added the event types Created by Linear-GitHub Sync label May 23, 2024
@anikdhabal anikdhabal requested a review from supalarry May 23, 2024 22:12
@anikdhabal
Copy link
Contributor Author

I think we should keep the save button because it's not optimal to save every time we change the title.

supalarry
supalarry previously approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@supalarry supalarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally works! Great work! : )

@keithwillcode
Copy link
Contributor

@PeerRich or @ciaranha Can you approve this before we merge?

@PeerRich PeerRich enabled auto-merge May 27, 2024 13:39
@PeerRich PeerRich added this pull request to the merge queue May 27, 2024
Merged via the queue into calcom:main with commit be7d45a May 27, 2024
16 of 23 checks passed
@shirazdole
Copy link

nice @anikdhabal — this will help our users a lot 🙏🏽

@anikdhabal
Copy link
Contributor Author

nice @anikdhabal — this will help our users a lot 🙏🏽

🙏🏽🙏🏽

@roeku
Copy link

roeku commented Jun 4, 2024

I think we should keep the save button because it's not optimal to save every time we change the title.

Regarding the save button, would it not make sense to disable it if no changes have occured?
Right now you can just keep pressing the save button and notifications will keep stacking up.

p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
@anikdhabal @PeerRich @p6l-richard
feat: autosave availability after making changes (calcom#14849)
3642f4f 
* feat: availability after making changes

* update

* update

* Update Schedule.tsx

---------

Co-authored-by: Peer Richelsen <peeroke@gmail.com>
@p6l-richard p6l-richard mentioned this pull request Jul 24, 2024
Closed
3 tasks
@emrysal emrysal mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

@supalarry supalarry supalarry left review comments

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync event types Created by Linear-GitHub Sync ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI Medium priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.

[CAL-3450] autosave availability after making changes
7 participants
@anikdhabal @keithwillcode @shirazdole @roeku @PeerRich @supalarry @Udit-takkar