refactor: loadUsers and move to separate file #15532
Conversation
dosubot
bot
added
bookings
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (06/21/24)1 reviewer was added to this PR based on Keith Williams's automation. |
| ? await loadUsersByEventType(eventType) | ||
| : await loadDynamicUsers(dynamicUserList, req); |
There was a problem hiding this comment.
separated the logic in these two functions
| * This method is mostly same as the one in UserRepository but it includes a lot more relations which are specific requirement here | ||
| * TODO: Figure out how to keep it in UserRepository and use it here | ||
| */ | ||
| export const findUsersByUsername = async ({ |
There was a problem hiding this comment.
no change in the code here.
There was a problem hiding this comment.
It looks like this logic is already in the UserRepository. Can we delete this duplicate code?
There was a problem hiding this comment.
this function returns few more fields(credentials and metadata) than the static function in UserRepository.
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Eleven Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
| }; | ||
|
|
||
| const loadDynamicUsers = async (dynamicUserList: string[], currentOrgDomain: string | null) => { | ||
| if (!Array.isArray(dynamicUserList) || dynamicUserList.length === 0) { |
There was a problem hiding this comment.
| if (!Array.isArray(dynamicUserList) || dynamicUserList.length === 0) { | |
| if (dynamicUserList.length === 0) { |
|
|
||
| const loadDynamicUsers = async (dynamicUserList: string[], currentOrgDomain: string | null) => { | ||
| if (!Array.isArray(dynamicUserList) || dynamicUserList.length === 0) { | ||
| throw new Error("dynamicUserList is not properly defined or empty."); |
There was a problem hiding this comment.
| throw new Error("dynamicUserList is not properly defined or empty."); | |
| throw new Error("dynamicUserList is empty."); |
* refactor: loadUsers and move to separate file * fix: improvement --------- Co-authored-by: Keith Williams <keithwillcode@gmail.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)