feat: Multiple Private links per Event Type #15896

Souptik2001 · 2024-07-24T18:36:59Z

What does this PR do?

Implements single-use links feature!

Disclaimer: Contains schema changes and migrations. ⚠️

https://www.loom.com/share/cb93616c775a4704bdc7590c6c1aa58e?sid=06bb210e-fd7b-4772-827a-e1d77e460ff3

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Please check the above loom video, which contains the detailed walkthrough. 👆

Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>

vercel · 2024-07-24T18:37:08Z

@Souptik2001 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Souptik2001 · 2024-07-24T18:39:52Z

apps/web/modules/event-types/views/event-types-single-view.tsx

+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+      // @ts-ignore
      updatedFields[typedKey] = undefined;


For some reason getting this type error on this line, and at all not able to fix this, therefore added this. If you have some solution please let me know. 🙏
FYI - few lines below if you see for this line the same ts-ignore is added, maybe it was also getting the same error.

Type error: Expression produces a union type that is too complex to represent.

graphite-app · 2024-07-24T18:40:11Z

Graphite Automations

"Add community label" took an action on this PR • (07/24/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (07/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (10/01/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Souptik2001 · 2024-07-24T18:54:18Z

Also one weird thing which is happening is that, for the newly added texts, like the "single_use_link_title", etc., when we change the tab the strings get's changed to the placeholder key, as you can see in the video.

Not sure if I am missing something related to this. 🤔

anikdhabal

Great work @Souptik2001

I've noticed in the Loom video that after destroying a single-use link, the page shows a 404 error, which is expected. However, it doesn't look good. Could you manage our own custom 404 page instead?

anikdhabal · 2024-07-24T19:01:49Z

Also one weird thing which is happening is that, for the newly added texts, like the "single_use_link_title", etc., when we change the tab the strings get's changed to the placeholder key, as you can see in the video.

Not sure if I am missing something related to this. 🤔

Every time you add a new translation key to the locales, you need to restart the server in order to see the text string

anikdhabal

Hey, please make this a setting toggle component, just like the other options. When enabled, it should create one link at that time. If users want more links, they can add them using the 'Add New Link' button, similar to how it currently works.

Souptik2001 · 2024-07-24T19:27:48Z

@anikdhabal

I've noticed in the Loom video that after destroying a single-use link, the page shows a 404 error, which is expected. However, it doesn't look good. Could you manage our own custom 404 page instead?

Actually it is using the default 404 page only. I have not created my own 404 page. As per my best guess, it is happening due to this PR - #15696
Please correct me if I am wrong. 🙏

Every time you add a new translation key to the locales, you need to restart the server in order to see the text string

I have actually restarted the server. Infact when I was recording the video, I was even not in dev mode. And as I said it is initially appearing fine (correct text is coming), but as soon as I change the tab and come back to the tab it is somehow changing to the translation key. I tried so much, but couldn't find a way to solve it. 😅

anikdhabal

After watching the Loom video, I feel some changes are needed. Please address it first

Souptik2001 · 2024-07-24T19:36:33Z

Hey, please make this a setting toggle component, just like the other options. When enabled, it should create one link at that time. If users want more links, they can add them using the 'Add New Link' button, similar to how it currently works.

@anikdhabal Before making this major change, just wanted to confirm few things. Please let me know what do you think about this..

I initially thought about making it a toggle, but then thought that this was more like an "adding feature" than a "toggling feature".

If we add the toggle feature, then certain complexities/questions popup like -

What will happen when the user deletes the last remaining link? Will the toggle automatically close?
Will this "adding" behavior not make it little bit confusing with the private link feature, as the user will not be able to see the "add new link" button in the first place.

Considering these only I thought to simply make it like this.

Just taking suggestions. Please let me know your thoughts on this. 🙌

anikdhabal · 2024-07-24T20:28:27Z

@Souptik2001 take this as an example:-

60min._.Event.Type._.Cal.com.and.21.more.pages.-.Personal.-.Microsoft.Edge.2024-07-25.01-41-40.mp4

And when user deletes the last remaining link, the "add new link" button visible in the first place. How is now looking

Currently, the description is not structured; it needs to be more descriptive.

This is my thought on the improvements, but I suggest waiting until someone from the design approves your implementation and design.

Tagging @ciaranha to check this once.

Souptik2001 · 2024-07-25T06:26:52Z

Thanks @anikdhabal got it!

Ok waiting for @ciaranha's confirmation before proceeding on your suggested changes!

Souptik2001 · 2024-07-25T18:52:28Z

Hey @ciaranha Any update on this? 🙌

keithwillcode

Thank you for your contribution.

to be merged, the logical changes in the backend need unit/integration tests to be added.

Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>

Souptik2001 · 2024-07-30T06:30:35Z

Thanks @keithwillcode . Added e2e tests covering all scenarios of single-use links -

Single use links can be added.
Single use links can be removed.
Single use links should be auto-destroyed on use.

Please let me know if anything else needs to be added.

Here's a video of the last test -

https://www.loom.com/share/a24e5fa1ba5f4469b01af12429e914b8?sid=1b898285-d84d-44c4-b867-3d6aca7685f0

cc: @anikdhabal

packages/features/ee/managed-event-types/lib/handleChildrenEventTypes.ts

Fixed

Amit91848 · 2024-09-22T12:29:37Z

Made some changes @Souptik2001 type checks and unit tests should pass now. Thank you for your contribution.

Tested and LGTM now 🚀. Will wait for others approval as well

github-actions · 2024-09-22T12:53:49Z

E2E results are ready!

Workflow #33404.1 latest results

Alexander-Frost · 2024-09-25T01:52:55Z

Hey guys -- this PR helps fix an issue we are facing as well. Can we get 👀 on it to merge this in?

@CarinaWolli @anikdhabal @keithwillcode

apps/web/lib/d/[link]/[slug]/getServerSideProps.tsx

anikdhabal · 2024-09-25T03:00:21Z

Hey guys -- this PR helps fix an issue we are facing as well. Can we get 👀 on it to merge this in?

Hey @Alexander-Frost , by this week man🙏

Alexander-Frost · 2024-09-27T02:29:32Z

Bumping this!

anikdhabal

Hey @Souptik2001 Can you replace single-use links with multiple private links in all places? Apart from this, all things are okay 🙏

Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>

Souptik2001 · 2024-09-28T10:49:33Z

Hey @anikdhabal, Replaced single-use-lniks with multiple-private-links (type of words) throughout the PR. ✅

anikdhabal · 2024-10-01T11:06:29Z

@Souptik2001 sorry man, all things are okay now. Could you pls fix the conflicts?

Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>

Souptik2001 · 2024-10-01T11:32:26Z

@anikdhabal No problem! 🙂

Resolved the conflicts. ✅

Stale

Souptik2001 added 6 commits July 23, 2024 17:26

feat: Change hashedLink field to array

d5423c6

Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>

feat: Implement core single-use links logic

3ce34e4

Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>

fix: Get private link from list of hashedLinks on event list page

03a3482

Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>

fix: Fix defalut single-use links form field value

42022b8

Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>

fix: Fix some type errors while compiling

4c20826

Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>

fix: Use onChange callback instead of setting form values directly

7e872d4

Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>

github-actions bot added event-types area: event types, event-types Medium priority Created by Linear-GitHub Sync ✨ feature New feature or request ❗️ migrations contains migration files labels Jul 24, 2024

graphite-app bot requested a review from a team July 24, 2024 18:38

graphite-app bot added the community Created by Linear-GitHub Sync label Jul 24, 2024

Souptik2001 commented Jul 24, 2024

View reviewed changes

anikdhabal reviewed Jul 24, 2024

View reviewed changes

anikdhabal requested changes Jul 24, 2024

View reviewed changes

anikdhabal requested a review from ciaranha July 24, 2024 20:29

keithwillcode previously requested changes Jul 29, 2024

View reviewed changes

Souptik2001 added 2 commits July 30, 2024 09:26

Merge branch 'main' into feature-15776-single-use-link

0542141

feat: Add e2e tests for single-use links

c6a3248

Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>

Amit91848 added 2 commits September 22, 2024 13:31

More merge conflict fix and refactor

28ac71d

fix tests, code refactor

a8effb9

Amit91848 reviewed Sep 22, 2024

View reviewed changes

packages/features/ee/managed-event-types/lib/handleChildrenEventTypes.ts Show resolved Hide resolved

Amit91848 reviewed Sep 22, 2024

View reviewed changes

packages/features/ee/managed-event-types/lib/handleChildrenEventTypes.ts Outdated Show resolved Hide resolved

Amit91848 added 2 commits September 22, 2024 16:17

fix: type check

dd65bc3

fix: duration config and keep links when updating event type

182eacc

Amit91848 requested a review from anikdhabal September 22, 2024 12:29

Amit91848 added the ready-for-e2e label Sep 22, 2024

fix: e2e

ad7a752

anikdhabal reviewed Sep 25, 2024

View reviewed changes

apps/web/lib/d/[link]/[slug]/getServerSideProps.tsx Show resolved Hide resolved

calcom deleted a comment from Souptik2001 Sep 25, 2024

anikdhabal requested changes Sep 27, 2024

View reviewed changes

refactor: Replace single-use-links with multiple-private-links

a3dcd2f

Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>

Merge branch 'main' into feature-15776-single-use-link

f6588a0

Signed-off-by: Souptik Datta <souptikdatta2001@gmail.com>

github-actions bot added the Stale label Oct 1, 2024

graphite-app bot requested a review from a team October 1, 2024 11:31

github-actions bot removed the Stale label Oct 2, 2024

anikdhabal approved these changes Oct 2, 2024

View reviewed changes

anikdhabal merged commit 2a1dc61 into calcom:main Oct 2, 2024
31 of 38 checks passed

anikdhabal mentioned this pull request Oct 2, 2024

Multiple Private links calcom/docs#152

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Multiple Private links per Event Type #15896

feat: Multiple Private links per Event Type #15896

Souptik2001 commented Jul 24, 2024 •

edited by CarinaWolli

Loading

vercel bot commented Jul 24, 2024

Souptik2001 Jul 24, 2024

graphite-app bot commented Jul 24, 2024 •

edited

Loading

Souptik2001 commented Jul 24, 2024

anikdhabal left a comment

anikdhabal commented Jul 24, 2024

anikdhabal left a comment •

edited

Loading

Souptik2001 commented Jul 24, 2024

anikdhabal left a comment •

edited

Loading

Souptik2001 commented Jul 24, 2024

anikdhabal commented Jul 24, 2024

Souptik2001 commented Jul 25, 2024

Souptik2001 commented Jul 25, 2024

keithwillcode left a comment

Souptik2001 commented Jul 30, 2024

Amit91848 commented Sep 22, 2024

github-actions bot commented Sep 22, 2024 •

edited

Loading

Alexander-Frost commented Sep 25, 2024 •

edited

Loading

anikdhabal commented Sep 25, 2024

Alexander-Frost commented Sep 27, 2024

anikdhabal left a comment •

edited

Loading

Souptik2001 commented Sep 28, 2024

anikdhabal commented Oct 1, 2024

Souptik2001 commented Oct 1, 2024

feat: Multiple Private links per Event Type #15896

feat: Multiple Private links per Event Type #15896

Conversation

Souptik2001 commented Jul 24, 2024 • edited by CarinaWolli Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

vercel bot commented Jul 24, 2024

Souptik2001 Jul 24, 2024

Choose a reason for hiding this comment

graphite-app bot commented Jul 24, 2024 • edited Loading

Graphite Automations

Souptik2001 commented Jul 24, 2024

anikdhabal left a comment

Choose a reason for hiding this comment

anikdhabal commented Jul 24, 2024

anikdhabal left a comment • edited Loading

Choose a reason for hiding this comment

Souptik2001 commented Jul 24, 2024

anikdhabal left a comment • edited Loading

Choose a reason for hiding this comment

Souptik2001 commented Jul 24, 2024

anikdhabal commented Jul 24, 2024

Souptik2001 commented Jul 25, 2024

Souptik2001 commented Jul 25, 2024

keithwillcode left a comment

Choose a reason for hiding this comment

Souptik2001 commented Jul 30, 2024

Amit91848 commented Sep 22, 2024

github-actions bot commented Sep 22, 2024 • edited Loading

E2E results are ready!

Alexander-Frost commented Sep 25, 2024 • edited Loading

anikdhabal commented Sep 25, 2024

Alexander-Frost commented Sep 27, 2024

anikdhabal left a comment • edited Loading

Choose a reason for hiding this comment

Souptik2001 commented Sep 28, 2024

anikdhabal commented Oct 1, 2024

Souptik2001 commented Oct 1, 2024

Souptik2001 commented Jul 24, 2024 •

edited by CarinaWolli

Loading

graphite-app bot commented Jul 24, 2024 •

edited

Loading

anikdhabal left a comment •

edited

Loading

anikdhabal left a comment •

edited

Loading

github-actions bot commented Sep 22, 2024 •

edited

Loading

Alexander-Frost commented Sep 25, 2024 •

edited

Loading

anikdhabal left a comment •

edited

Loading