fix: broken ui in edit location dialog issue

[anikdhabal]

What does this PR do?

• Fixes (Very annoying) Guest doesn't see updated meeting link on booking page #15497
• Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• N/A- I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• N/A-I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

• Are there environment variables that should be set?
• What are the minimal test data to have?
• What is expected (happy path) to have (input and output)?
• Any other important info that could help to test that PR

Checklist

• I haven't read the contributing guide
• My code doesn't follow the style guidelines of this project
• I haven't commented my code, particularly in hard-to-understand areas
• I haven't checked if my changes generate no new warnings

[vercel]

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[graphite-app]

Graphite Automations

"Add community label" took an action on this PR • (07/31/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (07/31/24)

1 reviewer was added to this PR based on Keith Williams's automation.

[Udit-takkar]

The code looks fine but in handleNewBooking we have this complex logic to set videoCallUrl

videoCallUrl =
          metadata.hangoutLink ||
          createdOrUpdatedEvent?.url ||
          organizerOrFirstDynamicGroupMemberDefaultLocationUrl ||
          getVideoCallUrlFromCalEvent(evt) ||
          videoCallUrl;

we are updating metadata in L131 in packages/trpc/server/routers/viewer/bookings/editLocation.handler.ts but not updating in booking table.

and we are not updating calendar event (evt) after

const updatedResult = await eventManager.updateLocation(evt, booking);

So I am not sure if

 metadata: {
           ...(typeof booking.metadata === "object" ? booking.metadata : {}),
           ...(location.startsWith("http") ? { videoCallUrl: location } : {}),
         },

would handle all the cases

[github-actions]

This PR is being marked as stale due to inactivity.

[github-actions]

This PR is being marked as stale due to inactivity.

[anikdhabal]

Looks like the location change issue has been fixed, so we only need to fix the broken UI

[github-actions]

E2E results are ready!

• Workflow #34542.1 latest results