Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add sensible default size for svg icons #16159

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

zomars
Copy link
Member

@zomars zomars commented Aug 9, 2024

What does this PR do?

Follow up to #16135 Updated the default size of the Icon component to 16.

What changed?

The default size argument in the Icon component was set to 16 px. This change ensures that the Icon component will have a default size of 16 px if no size is provided.

How to test?

  • Include the Icon component in a UI without specifying the size.
  • Verify that the icon displayed is of 16 px.

Why make this change?

This change sets a standard default size for icons which can help in maintaining consistency in the UI elements of the application.


Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 8:11pm
calcom-web-canary ⬜️ Ignored (Inspect) Aug 9, 2024 8:11pm

@keithwillcode keithwillcode added core area: core, team members only foundation labels Aug 9, 2024
Copy link
Member Author

zomars commented Aug 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zomars and the rest of your teammates on Graphite Graphite

@zomars zomars marked this pull request as ready for review August 9, 2024 20:12
@graphite-app graphite-app bot requested a review from a team August 9, 2024 20:12
@dosubot dosubot bot added the ui area: UI, frontend, button, form, input label Aug 9, 2024
Copy link

graphite-app bot commented Aug 9, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (08/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better than before
image

@zomars zomars enabled auto-merge (squash) August 9, 2024 20:40
@zomars zomars merged commit 829dd93 into main Aug 10, 2024
70 of 90 checks passed
@zomars zomars deleted the fix_add_sensible_default_size_for_svg_icons branch August 10, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only foundation ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants