fix: cross domain SVG sprites #16244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
ui
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
zomars
commented
Aug 16, 2024
| export function IconSprites() { | ||
| return ( | ||
| <SVG | ||
| src={`${process.env.NEXT_PUBLIC_WEBAPP_URL}/icons/sprite.svg?v=${process.env.NEXT_PUBLIC_CALCOM_VERSION}`} |
There was a problem hiding this comment.
This will help caching aggressively between releases
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (08/16/24)1 reviewer was added to this PR based on Keith Williams's automation. |
3 tasks
PeerRich
approved these changes
Aug 16, 2024
E2E results are ready! |
|
Can confirm this works for atoms as well! @zomars YOU ARE A LEGEND! ❤️ |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #16135
Implemented icon sprite fetching to avoid CORS issues in Atoms, Embeds and Orgs subdomains.
What changed?
IconSpritescomponent to render SVG sprites inlineIconcomponent to use local references instead of external SVG filesreact-inlinesvglibrary for efficient SVG handlingIconSpritesandCacheProviderHow to test?
Why make this change?
This change optimizes icon loading by using SVG sprites, which reduces the number of HTTP requests and improves overall page load performance. By rendering icons inline and utilizing a cache provider, we enhance the efficiency of SVG handling across the application.
More info on the SVG CORS subject:
https://oreillymedia.github.io/Using_SVG/extras/ch10-cors.html
Mandatory Tasks (DO NOT REMOVE)