refactor: enable infinite scrolling for all #16463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithwillcode
added
core
Udit-takkar
commented
Sep 2, 2024
Comment on lines
-1635
to
-1641
| const { data, status, error } = trpc.viewer.eventTypes.getByViewer.useQuery(filters && { filters }, { | ||
| refetchOnWindowFocus: false, | ||
| gcTime: 1 * 60 * 60 * 1000, | ||
| staleTime: 1 * 60 * 60 * 1000, | ||
| enabled: !isInfiniteScrollEnabled, | ||
| }); | ||
|
|
There was a problem hiding this comment.
don't need getByViewer now
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Udit-takkar
commented
Sep 2, 2024
| ); | ||
| }; | ||
|
|
||
| const InfiniteMobileTeamsTab: FC<InfiniteMobileTeamsTabProps> = (props) => { |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (09/02/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (09/02/24)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
dosubot
bot
added
ui
Udit-takkar
force-pushed
the
refactor/infinite-event-types
branch
from
bc2f5e9
to
de0b7b3
Compare
|
One E2E Test Failing |
alishaz-polymath
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Tests are clear, tested and works. Code looks good too 🚀
Great work @Udit-takkar
emrysal
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TODO:-
update tests
Fixes #XXXX (GitHub issue number)
Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)
Now enabling #15949 for everyone.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?