Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ui overflow on phone for calendar settings #16661

Conversation

mhetreayush
Copy link
Contributor

@mhetreayush mhetreayush commented Sep 16, 2024

What does this PR do?

This PR fixes a UI bug in the calendar settings page on mobile which leads to the overflow of the Adding events to label. Check the screenshots below for a clear understaning.

Before fix screenshots:

  • Desktop:
desktop-before
  • Mobile:
mobile-before

After fix screenshots:

  • Desktop:
desktop-after
  • Mobile:
mobile-after

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

Copy link

vercel bot commented Sep 16, 2024

@mhetreayush is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Sep 16, 2024
@graphite-app graphite-app bot requested a review from a team September 16, 2024 09:07
@github-actions github-actions bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Sep 16, 2024
@mhetreayush mhetreayush force-pushed the fix-overflow-on-phone-for-calendar-settings branch from 20cc4cb to 02432be Compare September 16, 2024 09:09
Copy link

graphite-app bot commented Sep 16, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (09/16/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/02/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@Amit91848 Amit91848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @mhetreayus. This works but it does not look that good. We want to maintain the same layout, can you have the email go to the next line

@mhetreayush
Copy link
Contributor Author

mhetreayush commented Sep 16, 2024

@Amit91848

can you have the email go to the next line

By this, do you mean label should be above the email? or do you mean I should wrap the email such that it breaks into parts

Attaching a screenshot:

Screenshot 2024-09-16 at 3 53 17 PM

@Amit91848
Copy link
Contributor

No 'Adding events to' should be right next to the email like it is originally. Just make the email go to next line

@mhetreayush
Copy link
Contributor Author

Screenshot 2024-09-16 at 4 00 41 PM

I guess this is what you are asking for @Amit91848 (I have hardcoded the value in the codebase to check for overflow issues)

@mhetreayush mhetreayush force-pushed the fix-overflow-on-phone-for-calendar-settings branch 2 times, most recently from 32c883d to 4a3e62e Compare September 16, 2024 10:44
@Amit91848
Copy link
Contributor

Let me just confirm the layout and get back to you @mhetreayush

@mhetreayush
Copy link
Contributor Author

@Amit91848 Any updates here?

Copy link
Contributor

@Amit91848 Amit91848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mhetreayush , you can revert it back to "Adding events to" text below the email. Sorry for the extra work you had to do 🙏

  • Mobile:
mobile-after

@mhetreayush mhetreayush force-pushed the fix-overflow-on-phone-for-calendar-settings branch from 9b1f7be to 20cc4cb Compare September 17, 2024 15:29
@mhetreayush mhetreayush force-pushed the fix-overflow-on-phone-for-calendar-settings branch from 06d0f8f to e4f99a7 Compare September 17, 2024 15:35
@mhetreayush
Copy link
Contributor Author

No worries @Amit91848 , I reverted to the first commit (20cc4cb) .

@mhetreayush
Copy link
Contributor Author

@Amit91848 Any updates here?

Copy link
Contributor

@Amit91848 Amit91848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gap between Adding Events To and gmail should be reduced, keep it the same as it is currently. Otherwise changes look good 👍
Your changes: Screenshot 2024-09-22 121327

Current: Screenshot 2024-09-22 121345

@anikdhabal anikdhabal enabled auto-merge (squash) October 2, 2024 12:03
@anikdhabal anikdhabal merged commit a99e285 into calcom:main Oct 2, 2024
31 of 37 checks passed
Copy link
Contributor

github-actions bot commented Oct 2, 2024

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Bug: Adding events to - label in the setting/calendar page is overflowing in mobile view
3 participants