-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix ui overflow on phone for calendar settings #16661
fix: fix ui overflow on phone for calendar settings #16661
Conversation
@mhetreayush is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
20cc4cb
to
02432be
Compare
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (09/16/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (09/16/24)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (10/02/24)1 label was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr @mhetreayus. This works but it does not look that good. We want to maintain the same layout, can you have the email go to the next line
No 'Adding events to' should be right next to the email like it is originally. Just make the email go to next line |
I guess this is what you are asking for @Amit91848 (I have hardcoded the value in the codebase to check for overflow issues) |
32c883d
to
4a3e62e
Compare
Let me just confirm the layout and get back to you @mhetreayush |
@Amit91848 Any updates here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mhetreayush , you can revert it back to "Adding events to" text below the email. Sorry for the extra work you had to do 🙏
- Mobile:
9b1f7be
to
20cc4cb
Compare
06d0f8f
to
e4f99a7
Compare
No worries @Amit91848 , I reverted to the first commit (20cc4cb) . |
@Amit91848 Any updates here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E results are ready! |
What does this PR do?
This PR fixes a UI bug in the calendar settings page on mobile which leads to the overflow of the
Adding events to
label. Check the screenshots below for a clear understaning.Before fix screenshots:
After fix screenshots:
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist