feat: update vitest version v0.34 to V2.11 #16676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-brydon
changed the title
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (09/17/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (09/17/24)1 reviewer was added to this PR based on Keith Williams's automation. |
dosubot
bot
added
the
⬆️ dependencies
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
sean-brydon
changed the title
sean-brydon
commented
Sep 17, 2024
| "@types/jsdom": "^21.1.3", | ||
| "@types/jsonwebtoken": "^9.0.3", | ||
| "@vitest/ui": "^2.1.1", |
There was a problem hiding this comment.
Dev dep to get a lovely UI for running tests https://vitest.dev/guide/ui
sean-brydon
commented
Sep 17, 2024
There was a problem hiding this comment.
These dont need object containing as theyre exact matches
sean-brydon
commented
Sep 17, 2024
| @@ -16,14 +16,13 @@ const _testWithAndWithoutOrg = ( | |||
| const t = mode === "only" ? test.only : mode === "skip" ? test.skip : test; | |||
| t( | |||
| `${description} - With org`, | |||
| async ({ emails, sms, meta, task, onTestFailed, expect, skip }) => { | |||
There was a problem hiding this comment.
Meta is no longer coming from the base vitest test -
sean-brydon
commented
Sep 17, 2024
| @@ -16,14 +16,13 @@ const _testWithAndWithoutOrg = ( | |||
| const t = mode === "only" ? test.only : mode === "skip" ? test.skip : test; | |||
| t( | |||
| `${description} - With org`, | |||
| async ({ emails, sms, meta, task, onTestFailed, expect, skip }) => { | |||
| async ({ emails, sms, task, onTestFailed, expect, skip, onTestFinished }) => { | |||
There was a problem hiding this comment.
We need to include onTestFinished now when expanding base fixtures
sean-brydon
commented
Sep 17, 2024
| @@ -14,5 +14,5 @@ beforeEach(() => { | |||
| mockReset(prisma); | |||
| }); | |||
|
|
|||
| const prisma = mockDeep<PrismaClient>(); | |||
There was a problem hiding this comment.
Weirdly - TS infering this was a massive performance hit. Casting it to the same type seemed to fix some of my issues
E2E results are ready! |
zomars
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates vitest version from V0.34 to V2.11
.toContainshas breaking changes - we now have to.toEqual(expect.objectContaining(...)).toContainsnow only check if a array includes a value