Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new user detection for dub analytics #16695

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix: new user detection for dub analytics #16695

merged 1 commit into from
Sep 18, 2024

Conversation

zomars
Copy link
Member

@zomars zomars commented Sep 17, 2024 •
edited
Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 11:20pm
calcom-web-canary ⬜️ Ignored (Inspect) Sep 17, 2024 11:20pm

@zomars Graphite App
Copy link
Member Author

zomars commented Sep 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zomars and the rest of your teammates on Graphite Graphite

@keithwillcode keithwillcode added core area: core, team members only foundation labels Sep 17, 2024
@zomars zomars marked this pull request as ready for review September 17, 2024 23:20
@graphite-app graphite-app bot requested a review from a team September 17, 2024 23:21
@dosubot dosubot bot added the authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in label Sep 17, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 17, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (09/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (09/17/24)

1 label was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

E2E results are ready!

@zomars zomars merged commit 3a5325f into main Sep 18, 2024
45 of 101 checks passed
@zomars Graphite App
Copy link
Member Author

zomars commented Sep 18, 2024

Merge activity

@zomars zomars deleted the fix_new_user_detection_for_dub_analytics branch September 18, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithwillcode keithwillcode keithwillcode approved these changes

Assignees
No one assigned
Labels
authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in core area: core, team members only foundation ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zomars @keithwillcode