fix: type error on booking cancelled page #16716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithwillcode
added
core
dosubot
bot
added
bookings
Udit-takkar
commented
Sep 19, 2024
| @@ -323,7 +323,7 @@ function BookingListItem(booking: BookingItemProps) { | |||
| const urlSearchParams = new URLSearchParams({ | |||
| allRemainingBookings: isTabRecurring.toString(), | |||
| }); | |||
| if (booking.attendees[0].email) urlSearchParams.set("email", booking.attendees[0].email); | |||
| if (booking.attendees?.[0]?.email) urlSearchParams.set("email", booking.attendees[0].email); | |||
There was a problem hiding this comment.
Added a check here
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (09/19/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (09/19/24)1 label was added to this PR based on Keith Williams's automation. |
PeerRich
approved these changes
Sep 19, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
You won't be able to reproduce it locally as this only happens for some users. i tried hardcoding the API response from affected users to my local setup to reproduce it and found the error line
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Go to /bookings/cancelled page
Checklist