Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatic no show #16727

Merged
merged 53 commits into from
Oct 10, 2024
Merged

feat: automatic no show #16727

merged 53 commits into from
Oct 10, 2024

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Sep 19, 2024

What does this PR do?

Screenshot 2024-09-24 at 4 24 00 PM

  • Hosts need to be logged in to cal.com when they join cal video meeting so that we can detect whether they joined the meeting or not.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Go to any event type webhooks page
  2. Create webhook with two trigger events "After hosts doesn't join cal vide" , "After guest doesn't join cal video" and select time as 5 minutes.
  3. Create a booking and join the cal video link (make sure you are logged in as host)
  4. then you can run yarn dev:cron and update the scheduledAt date(in prisma studio) to any past date to execute the cron job tasks.

3) you can test the task triggerNoShowHost by importing this function in packages/features/bookings/lib/handleNewBooking/scheduleNoShowTriggers.ts and

~triggerHostNoShow(JSON.stringify({ bookingId:booking.id, webhook: subscribersHostsNoShowStarted[0])}~

and try booking a meeting.

3) Make a POST request to http://localhost:3000/api/cron/calVideoNoShowWebhookTriggers to trigger the webhooks.
You can comment this code

and change the startAfter date to past date like 26th sept so that these jobs are executed when you make the POST request

Copy link

linear bot commented Sep 19, 2024

@github-actions github-actions bot added enterprise area: enterprise, audit log, organisation, SAML, SSO High priority Created by Linear-GitHub Sync ✨ feature New feature or request labels Sep 19, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Sep 19, 2024
@Udit-takkar Udit-takkar added this to the v4.6 milestone Sep 19, 2024
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 3:36pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 10, 2024 3:36pm

zomars
zomars previously approved these changes Oct 10, 2024
@Udit-takkar
Copy link
Contributor Author

I am not getting the host inside participants, even when I join cal video logged in as the host, participants shows the attendee's name

@CarinaWolli fixed this issue. user_id was not set for all hosts

zomars
zomars previously approved these changes Oct 10, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@formkit/auto-animate@1.0.0-beta.5 None 0 35.4 kB justin-schroeder
npm/bcryptjs@2.4.3 None 0 221 kB dcode
npm/ical.js@1.5.0 None 0 669 kB kewisch

🚮 Removed packages: npm/jose@4.15.9, npm/module-alias@2.2.3, npm/nodemailer@6.9.15

View full report↗︎

@emrysal
Copy link
Contributor

emrysal commented Oct 10, 2024

Happy to merge as well, everything works now on my local after @Udit-takkar's latest commit to fix organisers @zomars

@zomars zomars merged commit 395381d into main Oct 10, 2024
38 checks passed
@zomars zomars deleted the feat/automatic-no-show branch October 10, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ✨ feature New feature or request High priority Created by Linear-GitHub Sync ❗️ migrations contains migration files ready-for-e2e Urgent Created by Linear-GitHub Sync webhooks area: webhooks, callback, webhook payload
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4357] Auto no show detection for Cal Video hosts
6 participants