Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bookings limits error #16739

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix: bookings limits error #16739

merged 2 commits into from
Sep 20, 2024

Conversation

CarinaWolli
Copy link
Member

What does this PR do?

Fixes an existing bug with booking limits when host and attendees were in different timezones. Slots didn't load correctly and when trying to confirm the booking it was throwing Could not book the meeting. Booking Limit for this event type has been reached

@linear Linear
Copy link

linear bot commented Sep 20, 2024

CAL-3458 Slot shows as available even if event limit exceeds

CAL-3692 "Could not book the meeting. Booking Limit for this event type has been reached" -

@graphite-app graphite-app bot requested a review from a team September 20, 2024 13:00
@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking High priority Created by Linear-GitHub Sync linear Sync Github Issue from community members to Linear.app Medium priority Created by Linear-GitHub Sync Stale 🐛 bug Something isn't working 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Sep 20, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Sep 20, 2024
@dosubot dosubot bot added this to the v4.6 milestone Sep 20, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 1:01pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 1:01pm

emrysal
emrysal approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excellent 🚀

Coincidentally a similar fix to another bug I've been looking into

@emrysal emrysal enabled auto-merge (squash) September 20, 2024 13:03
@emrysal emrysal changed the title fix: bookings ilmits errror fix: bookings limits error Sep 20, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 20, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (09/20/24)

1 label was added to this PR based on Keith Williams's automation.

@emrysal emrysal merged commit b84cdc0 into main Sep 20, 2024
40 of 59 checks passed
@emrysal emrysal deleted the fix/booking-limits branch September 20, 2024 13:35
@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emrysal emrysal emrysal approved these changes

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working consumer core area: core, team members only High priority Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI linear Sync Github Issue from community members to Linear.app Medium priority Created by Linear-GitHub Sync ready-for-e2e Stale
Projects
None yet
Milestone
v4.6
3 participants
@CarinaWolli @emrysal @keithwillcode