Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: signup fixes #16800

Closed
wants to merge 1 commit into from
Closed

chore: signup fixes #16800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions apps/web/modules/signup-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,14 +456,14 @@ export default function Signup({
usernameTaken
}>
{premiumUsername && !usernameTaken
? `Create Account for ${getPremiumPlanPriceValue()}`
? `${t("create_account")} (${getPremiumPlanPriceValue()})`
: t("create_account")}
</Button>
</Form>
</div>
)}
{!displayEmailForm && (
<div className="mt-12">
<div className="mt-24">
{/* Upper Row */}
<div className="mt-6 flex flex-col gap-2 md:flex-row">
{isGoogleLoginEnabled ? (
Expand All @@ -472,12 +472,9 @@ export default function Signup({
loading={isGoogleLoading}
CustomStartIcon={
<img
className={classNames(
"text-subtle mr-2 h-4 w-4 dark:invert",
premiumUsername && "opacity-50"
)}
className={classNames("text-subtle mr-2 h-4 w-4", premiumUsername && "opacity-50")}
src="/google-icon-colored.svg"
alt=""
alt="Continue with Google Icon"
/>
}
className={classNames("w-full justify-center rounded-md text-center")}
Expand All @@ -501,7 +498,7 @@ export default function Signup({

router.push(url);
}}>
Continue with Google
{t("signin_with_google")}
</Button>
) : null}
</div>
Expand All @@ -528,7 +525,7 @@ export default function Signup({
setDisplayEmailForm(true);
}}
data-testid="continue-with-email-button">
Continue with email
{t("continue_with_email")}
</Button>
{isSAMLLoginEnabled ? (
<Button
Expand Down
1 change: 1 addition & 0 deletions apps/web/public/static/locales/en/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,6 +972,7 @@
"signin_with_google": "Sign in with Google",
"signin_with_saml": "Sign in with SAML",
"signin_with_saml_oidc": "Sign in with SAML/OIDC",
"continue_with_email": "Continue with email",
"last_used": "Last used",
"you_will_need_to_generate": "You will need to generate an access token from your old scheduling tool.",
"import": "Import",
Expand Down
2 changes: 1 addition & 1 deletion packages/app-store/stripepayment/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ export function getPerSeatPlanPrice(): string {
}

export function getPremiumPlanPriceValue() {
return "$29/mo";
return "$29/month";
}
Loading