feat: New UI for SignUp / Login #16802

hbjORbj · 2024-09-24T20:13:53Z

What does this PR do?

Fixes CAL-4365, 4366
Design: Checked with Ciaran ✅
Logic updates:

Decouple google sign-in from email sign-up form values (disabled prop or searchQueryParams that is added to Google auth url no longer depend on sign-up form values)
When signup URL link has token param, display the email form w/o a back button
Email form will have a button saying "Create Account with SAML" if user clicked the "SAML" button rather than "Continue with email"
"Create Account with SAML" is disabled if email / username isn't there
Remove password field for SAML signup

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Test /signup and /auth/login

… value

github-actions · 2024-09-24T20:14:08Z

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "Draft" found in pull request title "Draft: feat: New UI for SignUp / Login". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

graphite-app · 2024-09-24T20:15:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/24/24)

1 reviewer was added to this PR based on Keith Williams's automation.

vercel · 2024-09-24T20:16:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Sep 26, 2024 6:50pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Sep 26, 2024 6:50pm

hbjORbj · 2024-09-26T16:09:42Z

In our current logic, SAML button is coupled with the email form. They must be on the same page, or we need to change the logic. Talking with Ciaran now

hbjORbj · 2024-09-26T17:11:41Z

apps/web/modules/signup-view.tsx

+                      disabled={
+                        !!formMethods.formState.errors.username ||
+                        !!formMethods.formState.errors.email ||
+                        !formMethods.getValues("email") ||


hbjORbj · 2024-09-26T17:20:26Z

apps/web/modules/signup-view.tsx

-                        return;
-                      }
+            {/* Form Container */}
+            {displayEmailForm && (


hbjORbj · 2024-09-26T17:21:13Z

apps/web/modules/signup-view.tsx

+                  />
+
+                  {/* Password */}
+                  {!isSamlSignup && (


hbjORbj · 2024-09-26T17:21:35Z

apps/web/modules/signup-view.tsx

+                        !!formMethods.formState.errors.username ||
+                        !!formMethods.formState.errors.email ||
+                        !formMethods.getValues("email") ||
+                        !formMethods.getValues("username") ||


hbjORbj and others added 18 commits September 19, 2024 00:46

update UI of signup, login pages

9e970b1

remove disabled state from google sign-in

cade3ce

Put isGoogleLoginEnabled to its place + fix displaySignupForm default…

c14d58f

… value

Rename Signup flow test -> Email Signup flow test

6f90603

add data-testid to continue with email button

9f2df85

completely decouble formMethods values from google sign in

e678b33

fix

7cbe9cb

Merge origin/main

60a2a01

refactor

8cb1795

add signup page test

0fadb58

revert yarn.lock

f7f0d1b

Merge branch 'main' into feature/new-signup-flow

d850f66

fix e2e test

7a60b18

add saml in signup

1174f86

add saml in signin

7197223

revert

2dd2ae4

remove space

a3bfed8

signup fixes

56a5ee0

hbjORbj mentioned this pull request Sep 24, 2024

chore: signup fixes #16800

Closed

keithwillcode added consumer core area: core, team members only labels Sep 24, 2024

dosubot bot added ui area: UI, frontend, button, form, input ✨ feature New feature or request labels Sep 24, 2024

graphite-app bot requested a review from a team September 24, 2024 20:14

fix login view

c5ec4a5

hbjORbj marked this pull request as draft September 24, 2024 20:17

hbjORbj changed the title ~~Draft: feat: New UI for SignUp / Login~~ feat: New UI for SignUp / Login Sep 24, 2024

improve text

7a10f83

vercel bot deployed to Preview – api September 26, 2024 16:03 View deployment

change button copy

b9dd309

vercel bot deployed to Preview – api September 26, 2024 16:12 View deployment

vercel bot deployed to Preview – dev September 26, 2024 16:26 View deployment

hbjORbj added 2 commits September 26, 2024 12:46

new design

cf2eeaf

password is not required for saml

71bf7e9

vercel bot deployed to Preview – api September 26, 2024 16:54 View deployment

fix

8528d05

vercel bot deployed to Preview – api September 26, 2024 17:10 View deployment

hbjORbj commented Sep 26, 2024

View reviewed changes

make saml button disabled if username is not there

840c7a2

hbjORbj commented Sep 26, 2024

View reviewed changes

apps/web/modules/signup-view.tsx

return;

}

{/* Form Container */}

{displayEmailForm && (

Copy link

Contributor Author

hbjORbj Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flag

vercel bot deployed to Preview – api September 26, 2024 17:20 View deployment

hbjORbj commented Sep 26, 2024

View reviewed changes

apps/web/modules/signup-view.tsx

/>

{/* Password */}

{!isSamlSignup && (

Copy link

Contributor Author

hbjORbj Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flag

hbjORbj commented Sep 26, 2024

View reviewed changes

vercel bot deployed to Preview – dev September 26, 2024 17:34 View deployment

Merge branch 'main' into feature/new-signup-flow

5e7abbb

vercel bot deployed to Preview – api September 26, 2024 17:45 View deployment

vercel bot deployed to Preview – dev September 26, 2024 17:52 View deployment

fix

79c9ecc

vercel bot deployed to Preview – api September 26, 2024 18:01 View deployment

vercel bot deployed to Preview – dev September 26, 2024 18:10 View deployment

Merge branch 'main' into feature/new-signup-flow

7cf2012

joeauyeung approved these changes Sep 26, 2024

View reviewed changes

vercel bot deployed to Preview – api September 26, 2024 18:58 View deployment

vercel bot deployed to Preview – dev September 26, 2024 19:06 View deployment

hbjORbj merged commit 90f6c7e into main Sep 26, 2024
38 checks passed

hbjORbj deleted the feature/new-signup-flow branch September 26, 2024 19:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: New UI for SignUp / Login #16802

feat: New UI for SignUp / Login #16802

hbjORbj commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

graphite-app bot commented Sep 24, 2024

vercel bot commented Sep 24, 2024 •

edited

Loading

hbjORbj commented Sep 26, 2024

hbjORbj Sep 26, 2024

hbjORbj Sep 26, 2024

hbjORbj Sep 26, 2024

hbjORbj Sep 26, 2024

feat: New UI for SignUp / Login #16802

feat: New UI for SignUp / Login #16802

Conversation

hbjORbj commented Sep 24, 2024 • edited Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

github-actions bot commented Sep 24, 2024 • edited Loading

graphite-app bot commented Sep 24, 2024

Graphite Automations

vercel bot commented Sep 24, 2024 • edited Loading

hbjORbj commented Sep 26, 2024

hbjORbj Sep 26, 2024

Choose a reason for hiding this comment

hbjORbj Sep 26, 2024

Choose a reason for hiding this comment

hbjORbj Sep 26, 2024

Choose a reason for hiding this comment

hbjORbj Sep 26, 2024

Choose a reason for hiding this comment

hbjORbj commented Sep 24, 2024 •

edited

Loading

github-actions bot commented Sep 24, 2024 •

edited

Loading

vercel bot commented Sep 24, 2024 •

edited

Loading