fix: theme is not configured in app router #16889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/01/24)1 reviewer was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
E2E results are ready! |
hbjORbj
commented
Oct 1, 2024
| test.describe("Change Theme Test", () => { | ||
| test("change theme to dark", async ({ page, users }) => { | ||
| const pro = await users.create(); | ||
| testBothFutureAndLegacyRoutes.describe("Change Theme Test", () => { |
There was a problem hiding this comment.
adding testBothFutureAndLegacyRoutes to test app router pages
There was a problem hiding this comment.
Can you turn APP_ROUTER_SETTINGS_MY_ACCOUNT_ENABLED to 1 for dev? @keithwillcode
Otherwise, testBothFutureAndLegacyRoutes will just test pages router twice
hbjORbj
force-pushed
the
fix/theme-app-router
branch
from
e7f9fec
to
8ae85c9
Compare
sean-brydon
reviewed
Oct 1, 2024
| @@ -51,7 +51,7 @@ export function WithLayout<T extends Record<string, any>>({ | |||
| requiresLicense={requiresLicense || !!(Page && "requiresLicense" in Page && Page.requiresLicense)} | |||
| nonce={nonce} | |||
| themeBasis={null} | |||
| isThemeSupported={!!(Page && "isThemeSupported" in Page && Page.isThemeSupported)} | |||
| isThemeSupported={Page && "isThemeSupported" in Page ? (Page.isThemeSupported as boolean) : undefined} | |||
There was a problem hiding this comment.
NIT: I think isThemeSupported={Page?.isThemeSupported ?? undefined} has the same effect here and is a lot more readable
Suggested change
| isThemeSupported={Page && "isThemeSupported" in Page ? (Page.isThemeSupported as boolean) : undefined} | |
| isThemeSupported=isThemeSupported={Page?.isThemeSupported ?? undefined} |
There was a problem hiding this comment.
Page?.isThemeSupported will throw type error :( Feel free to make tweaks
sean-brydon
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist