Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n for app router #16909

Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix: i18n for app router #16909

merged 2 commits into from
Oct 2, 2024

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Oct 2, 2024

What does this PR do?

  • Fixes CAL-4448 (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 5:54pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 5:54pm

@hbjORbj hbjORbj changed the title fix: i18n translations app router fix: i18n for app router Oct 2, 2024
@graphite-app graphite-app bot requested a review from a team October 2, 2024 17:40
@keithwillcode keithwillcode added consumer core area: core, team members only labels Oct 2, 2024
@dosubot dosubot bot added the i18n area: i18n, translations label Oct 2, 2024
@hbjORbj hbjORbj force-pushed the fix/translations-app-router branch from 3f13483 to 3051643 Compare October 2, 2024 17:40
Copy link

linear bot commented Oct 2, 2024

@hbjORbj hbjORbj requested review from emrysal and removed request for a team October 2, 2024 17:42
Copy link

graphite-app bot commented Oct 2, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/02/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

E2E results are ready!

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & it works; Code change looks simple enough ⚡

@emrysal emrysal merged commit 2146c04 into main Oct 2, 2024
40 checks passed
@emrysal emrysal deleted the fix/translations-app-router branch October 2, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only i18n area: i18n, translations ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants