Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip must be used within TooltipProvider #16918

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

muhammadspace
Copy link
Contributor

Fix #16833

After installing Cal.com for the first time, users are not able to run go through the setup process on the client due to PageWrapper not being applied to /auth/setup.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Do a fresh install of Cal.com; clone the repo into a new workspace and run yarn dev after installing dependencies
  2. Create a new Postgres DB so that Cal.com recognizes that a setup is required
  3. Head over to localhost:3000.
  4. After getting redirected to localhost:3000/auth/setup, an error will occur: "Tooltip must be used within TooltipProvider"
  • Are there environment variables that should be set?
    Nope
  • What are the minimal test data to have?
    An new DB with no users
  • What is expected (happy path) to have (input and output)?
    No errors when going to localhost:3000/auth/setup
  • Any other important info that could help to test that PR

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Oct 3, 2024
@graphite-app graphite-app bot requested a review from a team October 3, 2024 11:32
Copy link

vercel bot commented Oct 3, 2024

@muhammadspace is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added docker 🐛 bug Something isn't working labels Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fixes #16833". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added the ui area: UI, frontend, button, form, input label Oct 3, 2024
@muhammadspace muhammadspace changed the title fixes #16833 fix: fixes #16833 Oct 3, 2024
Copy link

graphite-app bot commented Oct 3, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/03/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/03/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/03/24)

1 label was added to this PR based on Keith Williams's automation.

@anikdhabal anikdhabal changed the title fix: fixes #16833 fix: Tooltip must be used within TooltipProvider Oct 3, 2024
Copy link
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find @muhammadspace

@anikdhabal anikdhabal enabled auto-merge (squash) October 3, 2024 15:15
@anikdhabal anikdhabal merged commit a64b775 into calcom:main Oct 3, 2024
49 of 59 checks passed
Copy link
Contributor

github-actions bot commented Oct 3, 2024

E2E results are ready!

@FrancoAlbarra
Copy link

i still get this error deploying on render
image

@FrancoAlbarra
Copy link

i still get this error deploying on render image

Also getting this error on console and the hole page goes blank first i get a error waring 505 but after a few seconds dissapears
image

Thanks you for reading i hope we can fix this soon,
regards

@anikdhabal
Copy link
Contributor

anikdhabal commented Oct 3, 2024

i still get this error deploying on render

Thanks for reporting; will check that. Also, these changes have not been shipped to production yet

@FrancoAlbarra
Copy link

i still get this error deploying on render

Thanks for reporting; will check that. Also, these changes have not been shipped to production yet

ok, i'll wait for the solution to be publish

@FrancoAlbarra
Copy link

any news on this?

@anikdhabal
Copy link
Contributor

anikdhabal commented Oct 5, 2024

any news on this?

Yeah, it's was shipped. Could you pls check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync docker ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip must be used within TooltipProvider
3 participants