Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add node-gyp as dev dependency #17058

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: add node-gyp as dev dependency #17058

merged 1 commit into from
Oct 11, 2024

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Oct 11, 2024 •
edited
Loading

What does this PR do?

  • To fix yarn install error
Screenshot 2024-10-10 at 23 11 43

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@hbjORbj hbjORbj requested a review from emrysal October 11, 2024 03:11
@graphite-app graphite-app bot requested a review from a team October 11, 2024 03:11
@hbjORbj hbjORbj requested review from joeauyeung and removed request for a team October 11, 2024 03:11
@dosubot dosubot bot added the ⬆️ dependencies Pull requests that update a dependency file label Oct 11, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Oct 11, 2024 3:11am
calcom-web-canary ⬜️ Ignored (Inspect) Oct 11, 2024 3:11am

@keithwillcode keithwillcode added consumer core area: core, team members only labels Oct 11, 2024
@socket-security Socket Security
Copy link

Report too large to display inline

View full report↗︎

@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 11, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

@emrysal emrysal merged commit 361889d into main Oct 11, 2024
43 of 80 checks passed
@emrysal emrysal deleted the fix/deasync-package branch October 11, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emrysal emrysal emrysal approved these changes

@joeauyeung joeauyeung Awaiting requested review from joeauyeung

Assignees
No one assigned
Labels
consumer core area: core, team members only ⬆️ dependencies Pull requests that update a dependency file ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbjORbj @emrysal @keithwillcode