Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add billing tab in platform navigation sidebar #17060

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: add billing tab in platform navigation sidebar #17060

merged 1 commit into from
Oct 11, 2024

Conversation

Ryukemeister
Copy link
Contributor

What does this PR do?

  • Shell got refactored and somehow the billing tab got removed from platform navigation sidebar, added it back.

Before

Screenshot 2024-10-11 at 11 44 39 AM

After

Screenshot 2024-10-11 at 11 44 58 AM

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

This can be tested in the webapp under /settings/platform

@dosubot dosubot bot added billing area: billing, stripe, payments, paypal, get paid platform Anything related to our platform plan 🐛 bug Something isn't working labels Oct 11, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Oct 11, 2024
@graphite-app graphite-app bot requested a review from a team October 11, 2024 06:20
@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 11, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (10/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/11/24)

1 label was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

@Ryukemeister Ryukemeister merged commit 2260ddc into main Oct 11, 2024
42 of 79 checks passed
@Ryukemeister Ryukemeister deleted the add-billing-tab-to-sidebar branch October 11, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supalarry supalarry supalarry approved these changes

Assignees
No one assigned
Labels
billing area: billing, stripe, payments, paypal, get paid 🐛 bug Something isn't working core area: core, team members only platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryukemeister @supalarry @keithwillcode