-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sugesting the possibility to define path parameter instead of the old way #1
Conversation
…y1 -> x2,y2 -> x3,y3 way. Old way still supported, and will be used if path is undefined.
l += 1; | ||
} while (lx !== undefined && ly !== undefined) | ||
if(params['path'] === undefined){ | ||
console.log("regular"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is debug. Write it out ofc.
Another way I think would be cool I can implement if needed is to take just an args list as a splat and all even indexes of the args will be x values all odd will be y So something like this path(1,2,1,3,1,4,1,5) That could be split and handled really cleanly |
I could do that, but I'm still not sure. I've been thinking about how to Currently, you already can construct the object with a loop: var obj = { So if I did implement this, you'd have to construct the array/object for I hope you understand; It's an interesting idea; I just need more time to -Caleb On Tue, Nov 22, 2011 at 5:22 PM, Austin <
|
Honestly why not have a convient line method, even if it's not portable to all the other methods it makes one just that much easier to use |
I actually have to agree with caleb on this one. If you really need a convenient line method, you could implement it yourself. If it is not usefull for the entire library, then why add it? |
I just like the option to structure params depending on how your application needs. I have no problem doing what I need in a fork, just throwing my 2cents in on a great plugin. On Nov 27, 2011, at 3:57 AM, Henrik Tudborgreply@reply.github.com wrote:
|
Sugesting the possibility to define path parameter instead of the x1,y1 -> x2,y2 -> x3,y3 way.
Old way still supported, and will be used if path is undefined.