Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the step resolution calculation for StepMarker and steps when default settings #636

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

BartoszKlonowski
Copy link
Member

This pull request fixes #606

It applies the fix found during the review of #581
The fix separates the meaning of step from the resolution of step(s) when calculating the layout of the StepMarker scenario render.

Copy link
Contributor

@draggie draggie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@BartoszKlonowski BartoszKlonowski merged commit f3fb557 into main Sep 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the issue with default min/max values with default step for custom StepMarker
2 participants