Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new arch android interface #654

Merged
merged 6 commits into from
Oct 14, 2024
Merged

fix: new arch android interface #654

merged 6 commits into from
Oct 14, 2024

Conversation

draggie
Copy link
Contributor

@draggie draggie commented Oct 8, 2024 •
edited
Loading

Summary:

fixes #652
Resolved incompatible interface generation for the codegen source.

Test Plan:

@draggie draggie self-assigned this Oct 8, 2024
vonovak
vonovak reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@vonovak vonovak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run the code but it looks okay to me, just added a comment about using doubles.

re "Tmp patch for invalid height calculation" in the description: that doesn't seem to be included

package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java Outdated Show resolved Hide resolved
@draggie @vonovak
Update package/android/src/oldarch/java/com/reactnativecommunity/slid…
5a5c829 
…er/ReactSliderManager.java

Co-authored-by: Vojtech Novak <vonovak@gmail.com>
@draggie
Copy link
Contributor Author

draggie commented Oct 10, 2024

@vonovak Thanks, I have removed the tmp solution from the description as after further investigation this issue is related to measure function from ViewManager not being called in some setups like RNTA

draggie and others added 2 commits October 10, 2024 13:48
@draggie @vonovak
Update package/android/src/oldarch/java/com/reactnativecommunity/slid…
4b393a7 
…er/ReactSliderManager.java

Co-authored-by: Vojtech Novak <vonovak@gmail.com>
@draggie @vonovak
Update package/android/src/oldarch/java/com/reactnativecommunity/slid…
a8d8d21 
…er/ReactSliderManager.java

Co-authored-by: Vojtech Novak <vonovak@gmail.com>
@chrfalch
Copy link
Contributor

chrfalch commented Oct 10, 2024 •
edited
Loading

Me and @vonovak made #657 - which might solve another problem in the same issue.

@BartoszKlonowski BartoszKlonowski merged commit ece95c3 into main Oct 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vonovak vonovak vonovak requested changes

@BartoszKlonowski BartoszKlonowski BartoszKlonowski approved these changes

@okwasniewski okwasniewski okwasniewski approved these changes

Assignees

@draggie draggie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slider has 0 height on Android with new architecture enabled
5 participants
@draggie @chrfalch @vonovak @okwasniewski @BartoszKlonowski