Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup logger exports #434

Merged
merged 3 commits into from
Jan 5, 2024
Merged

refactor: cleanup logger exports #434

merged 3 commits into from
Jan 5, 2024

Conversation

mdjastrzebski
Copy link
Member

Summary

Simplify reassure-logger package exports

Test plan

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 141dd8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@callstack/reassure-logger Minor
@callstack/reassure-compare Patch
@callstack/reassure-measure Patch
@callstack/reassure-cli Patch
reassure Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024 •
edited
Loading

Performance Comparison Report

  • Current: 415ae7d - 2024-01-05 10:40:34Z
  • Baseline: main (4352279) - 2024-01-05 10:39:42Z

Significant Changes To Duration

Name Type Duration Count
fib 32 function 239.8 ms → 248.3 ms (+8.5 ms, +3.6%) 1 → 1
fib 31 function 153.7 ms → 148.1 ms (-5.5 ms, -3.6%) 1 → 1
Show details
Name Type Duration Count
fib 32 function Baseline
Mean: 239.8 ms
Stdev: 5.3 ms (2.2%)
Runs: 245.8 245.8 245.2 244.7 240.3 238.4 236.4 235.6 232.8 232.7

Current
Mean: 248.3 ms
Stdev: 2.6 ms (1.0%)
Runs: 252.5 249.3 248.6 248.5 248.5 248.5 248.4 248.4 248.3 241.9		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 31 function Baseline
Mean: 153.7 ms
Stdev: 3.2 ms (2.1%)
Runs: 158.4 158.1 157.4 154.8 153.0 151.4 151.3 151.1 150.7 150.4

Current
Mean: 148.1 ms
Stdev: 6.0 ms (4.1%)
Runs: 152.8 151.7 150.9 150.7 150.6 150.5 150.3 150.2 138.8 135.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Async Component render 197.4 ms → 198.5 ms (+1.1 ms, +0.6%) 7 → 7
fib 30 function 89.0 ms → 90.2 ms (+1.2 ms, +1.4%) 1 → 1
Other Component 10 render 118.6 ms → 118.0 ms (-0.6 ms, -0.5%) 4 → 4
Other Component 10 legacy scenario render 121.2 ms → 118.6 ms (-2.6 ms, -2.1%) 4 → 4
Other Component 20 render 121.1 ms → 117.2 ms (-3.9 ms, -3.3%) 4 → 4
Show details
Name Type Duration Count
Async Component render Baseline
Mean: 197.4 ms
Stdev: 11.2 ms (5.7%)
Runs: 216 209 207 200 196 195 194 190 190 177

Current
Mean: 198.5 ms
Stdev: 6.6 ms (3.3%)
Runs: 211 206 201 200 199 198 197 192 191 190		 Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
fib 30 function Baseline
Mean: 89.0 ms
Stdev: 2.4 ms (2.7%)
Runs: 90.4 90.4 90.2 90.2 90.2 90.1 89.9 89.4 84.5 84.3

Current
Mean: 90.2 ms
Stdev: 0.1 ms (0.1%)
Runs: 90.4 90.3 90.3 90.2 90.2 90.2 90.1 90.1 90.1 90.0		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Other Component 10 render Baseline
Mean: 118.6 ms
Stdev: 3.9 ms (3.3%)
Runs: 124 124 121 120 120 118 117 116 113 113

Current
Mean: 118.0 ms
Stdev: 4.7 ms (4.0%)
Runs: 127 121 121 121 118 116 116 116 114 110		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Other Component 10 legacy scenario render Baseline
Mean: 121.2 ms
Stdev: 3.4 ms (2.8%)
Runs: 129 124 123 121 121 120 119 119 119 117

Current
Mean: 118.6 ms
Stdev: 1.9 ms (1.6%)
Runs: 122 121 119 119 119 118 118 118 116 116		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Other Component 20 render Baseline
Mean: 121.1 ms
Stdev: 3.4 ms (2.8%)
Runs: 128 126 126 125 123 122 122 122 122 121 121 120 120 120 119 119 117 117 116 116

Current
Mean: 117.2 ms
Stdev: 6.3 ms (5.4%)
Runs: 131 128 121 121 121 121 120 119 118 118 117 117 115 115 115 113 111 110 107 105		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4

Changes To Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 141dd8a

@mdjastrzebski mdjastrzebski merged commit f9116d0 into main Jan 5, 2024
2 checks passed
@mdjastrzebski mdjastrzebski deleted the refactor/cleanup-logger-exports branch January 5, 2024 10:42
mdjastrzebski added a commit that referenced this pull request Feb 21, 2024
@mdjastrzebski
refactor: cleanup logger exports (#434)
08ee40f 
* chore: yarn upgrade

* refactor: cleanup logger exports

* chore: add change sets
mdjastrzebski added a commit that referenced this pull request Feb 21, 2024
@mdjastrzebski
feat: pre-v1 updates backport (#459)
b455bd4 
* refactor: rename `meassurePerformance` to `measureRenders` (#433)

* refactor: rename measurePerformance to measureRenders

* refactor: expose legacy `measurePerformance` alias

* chore: file naming

* chore: add changeset

* refactor: add `writeFile` option

* refactor: warn once

* docs: tweaks

* refactor: rename MeasureRendersOptions

* refactor: rename resetToDefaults

* refactor: cleanup logger exports (#434)

* chore: yarn upgrade

* refactor: cleanup logger exports

* chore: add change sets

* chore: upgrade deps 2024-01-05 (#435)

* chore: update some deps

* chore: upgrade babel

* chore upgrade types

* chore: upgrade line

* chore: upgrade react-native

* fix: fix logger outputing undefined in report

* chore: upgrade danger and turborepo

* chore: upgrade eslint config (#437)

* chore: upgrade eslint config

* refactor: fix issues

* chore: update test-app

* chore: fix ts

* chore: update snapshots

* chore: ignore `lib` in test

* chore: fix tests

* chore: fix ci dangerfile

* chore: simplify folder structure (#438)

* refactor: revert measureRenders name

# Conflicts:
#	packages/measure/CHANGELOG.md
#	packages/reassure/CHANGELOG.md
#	test-apps/native/CHANGELOG.md

* refactor: revert reset to defaults rename

* chore: reformat

* refactor: revert measureRender rename
mdjastrzebski added a commit that referenced this pull request Feb 21, 2024
@mdjastrzebski
refactor: cleanup logger exports (#434)
7e3bcff 
* chore: yarn upgrade

* refactor: cleanup logger exports

* chore: add change sets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdjastrzebski