-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove markdown builder #461
Conversation
🦋 Changeset detectedLatest commit: f6c7d9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Performance Comparison ReportSignificant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
Changes To CountThere are no entries Added ScenariosThere are no entries Removed ScenariosThere are no entries |
6836f73
to
f6c7d9c
Compare
export function header1(text: string) { | ||
return `# ${text}\n`; | ||
} | ||
|
||
export function header2(text: string) { | ||
return `## ${text}\n`; | ||
} | ||
|
||
export function header3(text: string) { | ||
return `### ${text}\n`; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seem to rely on the result being prefixed with a newline. Fortunately that appears to be the case everywhere it's currently used, but that probably at least deserves a comment if not a more robust implementation.
Summary
Replaces unmaintained
markdown-builder
with internal helper functions.Resolves: #451.
Test plan