Fix regexp_instr on Redshift #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the change to adapter resolution in dbt 0.20, redshift has been using the postgres version of the macro, which fails because the function `regexp_matches` exists on Postgres but not Redshift. While the `regexp_instr` does exist on Redshift, so the default was correct all along. This commit simply adds an explicit adapter for Redshift that is the same as the default adapter.
|
Very cool, thanks! I'll take a look today and should be able to merge this and #101 this weekend and cut a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the change to adapter resolution in dbt 0.20, redshift has been
using the postgres version of the macro, which fails because the
function
regexp_matchesexists on Postgres but not Redshift. While theregexp_instrdoes exist on Redshift, so the default was correct allalong.
This commit simply adds an explicit adapter for Redshift that is the
same as the default adapter.
This should fix #97