Fix sum_total in expect_multicolumn_sum_to_equal to accept column names #291
Conversation
|
Great catch, thanks for the PR! I think this is one of those holdovers from Great Expectations where tests are built against static values vs totals of other columns. Probably worth looking other tests as well. Would you mind also adding a test that covers this new use case of testing against the sum of another column? We currently only have a static test, i.e. - dbt_expectations.expect_multicolumn_sum_to_equal:
column_list: ["col_numeric_a", "col_numeric_b"]
sum_total: 4so we'll need something like - dbt_expectations.expect_multicolumn_sum_to_equal:
column_list: ["col_numeric_a", "col_numeric_b"]
sum_total: new_totals_column |
add test for column name in expect_multicolumn_sum_to_equal
|
Hopefully this is what you're looking for. If not let me know. |
I'll check it out! FYI, you probably figured this out since, but |
| @@ -9,7 +9,8 @@ | |||
| {% set expression %} | |||
| {% for column in column_list %} | |||
| sum({{ column }}){% if not loop.last %} + {% endif %} | |||
| {% endfor %} = {{ sum_total }} | |||
| {# the if just allows for column names or literal numbers #} | |||
| {% endfor %} = {% if sum_total is number %}{{sum_total}}{% else %}sum({{ sum_total }}){% endif %} | |||
|
FYI, updated the CI config on this PR to get Spark CI to pass. For some reason our CI configs breaks in dbt 1.7.x, but I'll fix that separately. CI is passing for you now 👍 |
clausherther
changed the title
Issue this PR Addresses/Closes
Closes #290
Summary of Changes
Just wrapped
sum_totalin Sum()Why Do We Need These Changes
This will allow a column name or a literal number to be used.
Reviewers
@clausherther