Add expect_table_column_count_to_equal_other_table_times_factor #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nysthee
force-pushed
the
feature/add-row-count-count-to-equal-other-table-times-factor
branch
from
9503293 to
9b72523
Compare
nysthee
force-pushed
the
feature/add-row-count-count-to-equal-other-table-times-factor
branch
from
9b72523 to
6d95d96
Compare
clausherther
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Hi @nysthee, thanks for submitting this, looks great. I added a small comment re: the integration, but I'll leave it up to you if you want to change that. Let me know either way and I'll go ahead and merge once you're ready.
| @@ -117,6 +117,9 @@ models: | |||
| max_value: 4 | |||
| - dbt_expectations.expect_table_row_count_to_equal_other_table: | |||
| compare_model: ref("data_test") | |||
| - dbt_expectations.expect_table_row_count_to_equal_other_table_times_factor: | |||
| compare_model: ref("data_test") | |||
| factor: 1 | |||
There was a problem hiding this comment.
Should we maybe introduce a new test column that is factored up something other than 1?
|
I agree, makes sense to make the test a bit more meaningful. I will do it and ping you once it’s there!
- - -
Thomas Nys
+32 475 269 452
https://calendly.com/thomasnys
On 9 April 2021 at 16:10:08, Claus Herther ***@***.***) wrote:
@clausherther approved this pull request.
Hi @nysthee, thanks for submitting this, looks great. I added a small comment re: the integration, but I'll leave it up to you if you want to change that. Let me know either way and I'll go ahead and merge once you're ready.
In integration_tests/models/schema_tests/schema.yml:
@@ -117,6 +117,9 @@ models:
max_value: 4
- dbt_expectations.expect_table_row_count_to_equal_other_table:
compare_model: ref("data_test")
+ - dbt_expectations.expect_table_row_count_to_equal_other_table_times_factor:
+ compare_model: ref("data_test")
+ factor: 1
Should we maybe introduce a new test column that is factored up something other than 1?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I added a new model with factor 2 number of rows of the original table (didn't bother with the content since we only care about the number of rows) |
|
@nysthee looks good, thanks! |
|
I will cut a new release this weekend, might wrap some other work into that. Thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
We have a use case where we have a table a and we want to validate that table b always has a row count that is equal to the row count in table a times a predefined factor.