Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement strictly for between tests #74

Merged
merged 13 commits into from
May 29, 2021
Merged

Implement strictly for between tests #74

merged 13 commits into from
May 29, 2021

Conversation

clausherther
Copy link
Contributor

@clausherther clausherther commented May 28, 2021 •
edited
Loading

This PR adds the option to make between tests evaluate boundaries strictly, i.e. not inclusive of the boundaries.

So, a test configuration like:

- dbt_expectations.expect_column_stdev_to_be_between:
    min_value: 0
    strictly: true

would result in an evaluation of > 0 instead of >= 0.

Closes #72

clausherther and others added 13 commits May 28, 2021 11:45
@clausherther
Initial implementation of strictly
c971f85
@clausherther
Update between tests to support strictly
f1ac162
@alieus
dispactching expect_table_row_count_to_equal (#64)
cd3ff97 
* dispactching expect_table_row_count_to_equal

* adding spaces between args

* Update expect_table_row_count_to_equal.sql

* dispatch more macros

Co-authored-by: Alieu <alieu.sanneh@avande.com>
@clausherther
Add stricly test to grouped expression
164ebd2
@clausherther
Update CHANGELOG
5b69c66
@clausherther
Update README
0834584
@clausherther
Initial implementation of strictly
3c7af66
@clausherther
Update between tests to support strictly
94e5715
@clausherther
Add stricly test to grouped expression
2b6bf1c
@clausherther
Update CHANGELOG
27705ad
@clausherther
Update README
90c1004
@clausherther
Merge branch 'add/issue-72-implement-strictly' of github.com:calogica…
9aa3d4c 
…/dbt-expectations into add/issue-72-implement-strictly
@clausherther
Adds missing group_by support
99f85e4
@clausherther clausherther merged commit 6634f3c into main May 29, 2021
@clausherther clausherther deleted the add/issue-72-implement-strictly branch May 29, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement strictly for between & greater tests
2 participants
@clausherther @alieus