Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added label support #101

Merged

Conversation

runefa
Copy link
Collaborator

@runefa runefa commented May 11, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

Copy link
Collaborator

@StrawnSC StrawnSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the linter issues? Basically the help text needs to be added and corrected:

  • We need help text for the label command group as well as the label add and remove commands
  • The new commands need parameter help text
  • The two command examples for the command az containerapp ingress traffic set are invalid (they use the old parameter (--traffic-weight)

You should also merge the latest commits on the may11 branch (I fixed the style issues on that branch) and rerun the style check

Having --ids support for revision label add probably doesn't make sense btw (IIRC the fix here is to have id_part=None for the name/rg params on that command)

The containerapp --name inferring doesn't seem to work (leaving off --name says (--name | --ids) are required)

src/containerapp/azext_containerapp/custom.py Outdated Show resolved Hide resolved
@StrawnSC
Copy link
Collaborator

StrawnSC commented May 11, 2022

Also this seems like a bug:

Screen Shot 2022-05-11 at 3 09 13 PM

Basically I had two revisions with a traffic split of 95/5. I renamed the 5% with the label "express". I then tried to adjust the weights to 50/50 with az containerapp ingress traffic set --label-weight express=50 -g {} -n {}

So it seems like adjusting weights with just a single value doesn't work when using labels?

Haroon Feisal added 4 commits May 11, 2022 19:28
… to no name given for revision command and latest passed. Added revision name inference from --revision to revision label add.
@runefa runefa merged commit 914a32b into calvinsID:may-11-2022-containerapp-release May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants