Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API-design-guidelines to add subscriptionMaxEvents #131

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

bigludo7
Copy link
Collaborator

@bigludo7 bigludo7 commented Feb 5, 2024

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature
  • documentation

What this PR does / why we need it:

Add management of subscriptionMaxEvents for notification subscription

Which issue(s) this PR fixes:

Fixes #90

Special notes for reviewers:

Discussion in issue 90

Changelog input

 release-note
- Add management of subscriptionMaxEvents for notification subscription

Additional documentation

This section can be blank.

docs

Add subscriptionMaxEvents
@bigludo7
Copy link
Collaborator Author

bigludo7 commented Feb 5, 2024

@rartych rartych changed the title Update API-design-guidelines to dd subscriptionMaxEvents Update API-design-guidelines to add subscriptionMaxEvents Feb 5, 2024
patrice-conil
patrice-conil previously approved these changes Feb 5, 2024
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@bigludo7
Copy link
Collaborator Author

Hello reviewers
Reminder on this one that has had been discussed in issue #90
@rartych @shilpa-padgaonkar @RubenBG7 @jordonezlucena
Thanks

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@jlurien
Copy link
Contributor

jlurien commented Feb 12, 2024

fyi @PedroDiez

PedroDiez
PedroDiez previously approved these changes Feb 12, 2024
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editorial suggestions

LGTM in advance

documentation/API-design-guidelines.md Outdated Show resolved Hide resolved
documentation/API-design-guidelines.md Outdated Show resolved Hide resolved
documentation/API-design-guidelines.md Outdated Show resolved Hide resolved
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
@bigludo7
Copy link
Collaborator Author

bigludo7 commented Mar 3, 2024

@PedroDiez @shilpa-padgaonkar may I request your validation and then merging this one?
It is open for some time and I think it's good for the team.
Thanks

PedroDiez
PedroDiez previously approved these changes Mar 4, 2024
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscription/Notification : adding a maxEventLimit attribute
5 participants