Update API-design-guidelines to add subscriptionMaxEvents #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add subscriptionMaxEvents
bigludo7
requested review from
shilpa-padgaonkar,
rartych,
patrice-conil,
RubenBG7 and
jordonezlucena
as code owners
|
rartych
changed the title
|
Hello reviewers |
|
fyi @PedroDiez |
PedroDiez
previously approved these changes
Feb 12, 2024
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
bigludo7
dismissed stale reviews from shilpa-padgaonkar and patrice-conil
via
188cd6d
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
|
@PedroDiez @shilpa-padgaonkar may I request your validation and then merging this one? |
bigludo7
dismissed stale reviews from shilpa-padgaonkar and PedroDiez
via
ee1d53d
shilpa-padgaonkar
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Add management of subscriptionMaxEvents for notification subscription
Which issue(s) this PR fixes:
Fixes #90
Special notes for reviewers:
Discussion in issue 90
Changelog input
Additional documentation
This section can be blank.