Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandate '+' in all phoneNumber formats #148

Conversation

fernandopradocabrillo
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

Update guidelines, common and glossary to mandate phone number '+' prefix in all formats

Which issue(s) this PR fixes:

Fixes #87

Copy link

@diegogonmar diegogonmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7
Copy link
Collaborator

bigludo7 commented Mar 7, 2024

Hello @PedroDiez @shilpa-padgaonkar @fernandopradocabrillo @rartych
My colleague @patrice-conil is on leave for a couple of weeks.
I provide the OK from Orange for this one.

@fernandopradocabrillo
Copy link
Contributor Author

hi @shilpa-padgaonkar , can you please review? thanks!

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM
@fernandopradocabrillo Ok from DT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mandate '+' in all Phone Number formats
6 participants